Development/compositor enhancements #924
Conversation
…tedRefreshRate parameter
…d update related components
…od, and update DefaultModifier
…fer configuration logic
…t and update related logic
… and expose new accessors
…removing unnecessary reference counting
|
b'## Copyright scan failure |
|
b'## Copyright scan failure |
… base for this new file,
pwielders
left a comment
pwielders
left a comment
There was a problem hiding this comment.
Minor: Can you remove all cerr streams. They cluther up the CLI, if it is running!
| To properly start Thunder with a Westeros compositor, use the following command: | ||
|
|
||
| ```shell | ||
| XDG_RUNTIME_DIR=/run LD_PRELOAD=libwesteros_gl.so WESTEROS_DRM_CARD=/dev/dri/card1 WESTEROS_GL_NO_VBLANK=1 WAYLAND_DISPLAY=wayland-0 Thunder -F |
There was a problem hiding this comment.
This is violating the "uniform configuration" rule for the Thunder product. We need to look at this in more detail, cause all configuration information should be coming from the json config file and not rely on environment variables set. I guess ,for example, the WESTEROS_DRM_CARD is a piece f informatin that is also in the json config. What if these cinflict ?
Compositor/lib/Mesa/drm/DRMTypes.cpp
Outdated
| drmModeObjectPropertiesPtr properties = drmModeObjectGetProperties(_descriptor, _objectId, static_cast<uint32_t>(_objectType)); | ||
|
|
||
| if (properties) { | ||
| std::cerr << __FILE__ << ":" << __LINE__ << std::endl; |
There was a problem hiding this comment.
This was probably for testing ? Please remove it as this clutters up the CLI if it is running :-)
Compositor/lib/Mesa/drm/DRMTypes.cpp
Outdated
| drmModePropertyBlobPtr result(nullptr); | ||
|
|
||
| uint64_t blobId; | ||
| std::cerr << __FILE__ << ":" << __LINE__ << std::endl; |
Remove console output.
ServerBufferTypehas been moved from theClientobject to a new Buffer object.ClientBufferTypewithin its own process space. The correspondingServerBufferTypeis then selected as the active content buffer for rendering.related PR
rdkcentral/ThunderClientLibraries#321