VPLAY-12568:Implement cancelReservation UVE-API#1007
Open
varshnie wants to merge 1 commit intodev_sprint_25_2from
Open
VPLAY-12568:Implement cancelReservation UVE-API#1007varshnie wants to merge 1 commit intodev_sprint_25_2from
varshnie wants to merge 1 commit intodev_sprint_25_2from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a new cancelReservation API surface for UVE by plumbing a CancelReservation() call from JS → PlayerInstanceAAMP → PrivateInstanceAAMP → CDAI ad manager (MPD).
Changes:
- Added
CancelReservation()toPlayerInstanceAAMPandPrivateInstanceAAMPpublic APIs. - Exposed
cancelReservation()to JavaScript viajsmediaplayer.cpp. - Added
CancelReservation()to CDAI interfaces and MPD ad manager classes.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
priv_aamp.h |
Declares PrivateInstanceAAMP::CancelReservation() API. |
priv_aamp.cpp |
Forwards cancel request to mCdaiObject. |
main_aamp.h |
Declares PlayerInstanceAAMP::CancelReservation() public API. |
main_aamp.cpp |
Forwards cancel request to private AAMP instance. |
jsbindings/jsmediaplayer.cpp |
Adds JS-callable cancelReservation() binding and registers it. |
AdManagerBase.h |
Extends CDAI base interface with CancelReservation(). |
admanager_mpd.h |
Declares MPD overrides for CancelReservation(). |
admanager_mpd.cpp |
Implements MPD forwarding, but leaves private implementation as TODO/empty. |
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
ffdd52b to
23db3c1
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
23db3c1 to
b755876
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
b755876 to
183997a
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
183997a to
324e893
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
324e893 to
d054ea6
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
d054ea6 to
d116573
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
d116573 to
f1d9403
Compare
Vinish100
reviewed
Feb 13, 2026
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
f1d9403 to
74c3559
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
74c3559 to
ac8b88f
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
ac8b88f to
939f965
Compare
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
939f965 to
daf6944
Compare
Reason for change:cancelReservation UVE call Test Procedure: Refer jira ticket Priority: P1 Signed-off-by: varshnie <varshniblue14@gmail.com>
varshnie
force-pushed
the
feature/VPLAY-12568
branch
from
daf6944 to
e574e56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:cancelReservation UVE call
Test Procedure: Refer jira ticket
Priority: P1
Signed-off-by: varshnie varshniblue14@gmail.com