VPLAY-11600 IsEmptyPeriod() with checkIframe=false when using AAMP TSB #725

jfagunde · 2025-12-03T10:21:00Z

Reason for Change: Change necessary prior to fixing VPLAY-11583

Summary of Changes:

Add ShouldCheckOnlyIframeAdaptation() helper function,
which returns false for AAMP TSB
Add IsEmptyPeriod() helper function
Replace StreamAbstraction mPlayRate with the new helper functions
Improved functions comments

Test Procedure: No regressions with AAMP TSB

Risk: Low

Reason for Change: This needs fixing before we can fix VPLAY-11583 Summary of Changes: * Call IsEmptyPeriod() with checkIframe=false for AAMP TSB * Use aamp->rate instead of rate in IsEmptyPeriod() * Improve comments and parameters name for GetPeriodDuration() and GetPeriodEndTime() Test Procedure: Verify no regressions when using AAMP TSB Risk: Low Signed-off-by: Jose Fagundez <[email protected]>

…ture/VPLAY-11600

Copilot

Pull request overview

This PR refactors the logic for checking empty periods in MPEG-DASH playback to support AAMP TSB (Time Shift Buffer) functionality. The key change introduces two new helper functions that centralize the decision of whether to check only iframe adaptations when determining if a period is empty. When using local AAMP TSB, the code now checks all adaptations regardless of playback rate, since the iframe track is not used in TSB mode.

Key Changes:

Added ShouldCheckOnlyIframeAdaptation() helper to encapsulate the logic for determining whether to check only iframe adaptations based on playback rate and TSB mode
Added IsEmptyPeriod() wrapper that uses the new helper to call the underlying MPD parse helper
Replaced 30+ call sites throughout fragmentcollector_mpd.cpp to use the new centralized functions

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
fragmentcollector_mpd.h	Added declarations for two new helper functions: `ShouldCheckOnlyIframeAdaptation()` and `IsEmptyPeriod()`
fragmentcollector_mpd.cpp	Implemented the two new helper functions and refactored all call sites to use them instead of inline checks, centralizing TSB-aware logic
AampMPDParseHelper.h	Improved documentation for `GetPeriodDuration()`, `GetPeriodEndTime()`, and `UpdateBoundaryPeriod()` with detailed parameter descriptions
AampMPDParseHelper.cpp	Updated documentation for `UpdateBoundaryPeriod()` and `GetPeriodEndTime()` to clarify parameter meanings

fragmentcollector_mpd.h

fragmentcollector_mpd.cpp

Address review comments made by Copilot Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

fragmentcollector_mpd.cpp

Address review comment made by Copilot Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

AampMPDParseHelper.h

AampMPDParseHelper.cpp

fragmentcollector_mpd.h

fragmentcollector_mpd.cpp

Co-authored-by: Copilot <[email protected]>

…ture/VPLAY-11600

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

fragmentcollector_mpd.cpp

…ture/VPLAY-11600

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

…ture/VPLAY-11600

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

test/utests/tests/FragmentCollectorMpdTests/FragmentCollectorMpdTestCases.cpp

Copilot · 2026-01-21T16:33:00Z

@jfagunde I've opened a new pull request, #893, to work on those changes. Once the pull request is ready, I'll request review from you.

…ll dereference (#893)

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

fragmentcollector_mpd.cpp

…ture/VPLAY-11600

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

AampMPDParseHelper.cpp

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

jfagunde added 4 commits October 31, 2025 13:30

Merge branch 'dev_sprint_25_2' of github.com:rdkcentral/aamp into fea…

b065a94

…ture/VPLAY-11600

Merge branch 'dev_sprint_25_2' of github.com:rdkcentral/aamp into fea…

10582d5

…ture/VPLAY-11600

Merge branch 'dev_sprint_25_2' of github.com:rdkcentral/aamp into fea…

ef5a92d

…ture/VPLAY-11600

Copilot AI review requested due to automatic review settings December 3, 2025 10:21

Copilot started reviewing on behalf of jfagunde December 3, 2025 10:21 View session

Copilot finished reviewing on behalf of jfagunde December 3, 2025 10:23

Copilot AI reviewed Dec 3, 2025

View reviewed changes

Apply suggestions from code review

0b1c778

Address review comments made by Copilot Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings December 3, 2025 10:49

Copilot started reviewing on behalf of jfagunde December 3, 2025 10:49 View session

Copilot finished reviewing on behalf of jfagunde December 3, 2025 10:52

Copilot AI reviewed Dec 3, 2025

View reviewed changes

fragmentcollector_mpd.cpp Outdated Show resolved Hide resolved

Apply suggestions from code review

0054a1c

Address review comment made by Copilot Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings December 3, 2025 10:54

Copilot started reviewing on behalf of jfagunde December 3, 2025 10:55 View session

Copilot finished reviewing on behalf of jfagunde December 3, 2025 10:58

Copilot AI reviewed Dec 3, 2025

View reviewed changes

jfagunde and others added 3 commits December 5, 2025 12:12

Apply suggestions from code review

3f22f9e

Co-authored-by: Copilot <[email protected]>

Fix build failure and add comment

94643f1

Merge branch 'dev_sprint_25_2' of github.com:rdkcentral/aamp into fea…

7d54c6a

…ture/VPLAY-11600

jfagunde requested a review from Copilot December 5, 2025 13:19

Copilot started reviewing on behalf of jfagunde December 5, 2025 13:19 View session

Copilot finished reviewing on behalf of jfagunde December 5, 2025 13:22

Copilot AI reviewed Dec 5, 2025

View reviewed changes

fragmentcollector_mpd.cpp Show resolved Hide resolved

fragmentcollector_mpd.cpp Show resolved Hide resolved

jfagunde added 4 commits December 5, 2025 20:26

Test ShouldCheckOnlyIframeAdaptation() in L1 tests

8cefb77

Test IsEmptyPeriod() in L1 tests

d97fbc5

Add comment clarifying the rate does not change

0a7d985

Merge branch 'dev_sprint_25_2' of github.com:rdkcentral/aamp into fea…

7b50ded

…ture/VPLAY-11600

jfagunde requested a review from Copilot December 9, 2025 09:06

Copilot started reviewing on behalf of jfagunde December 9, 2025 09:06 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

Merge branch 'dev_sprint_25_2' of github.com:rdkcentral/aamp into fea…

b41ef1a

…ture/VPLAY-11600

jfagunde requested a review from Copilot January 21, 2026 15:47

Copilot started reviewing on behalf of jfagunde January 21, 2026 15:47 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

test/utests/tests/FragmentCollectorMpdTests/FragmentCollectorMpdTestCases.cpp Show resolved Hide resolved

Copilot AI mentioned this pull request Jan 21, 2026

Initialize mMPDParseHelper in FragmentCollectorMpdTests to prevent null dereference #893

Merged

Initialize mMPDParseHelper in FragmentCollectorMpdTests to prevent nu…

c82d0aa

…ll dereference (#893)

jfagunde requested a review from Copilot January 21, 2026 16:46

Copilot started reviewing on behalf of jfagunde January 21, 2026 16:46 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

fragmentcollector_mpd.cpp Show resolved Hide resolved

jfagunde added 2 commits January 22, 2026 10:28

VPLAY-11600 Use ShouldCheckOnlyIframeAdaptation() to set isIframeTrack

89332c4

Merge branch 'dev_sprint_25_2' of github.com:rdkcentral/aamp into fea…

5671043

…ture/VPLAY-11600

jfagunde marked this pull request as ready for review January 23, 2026 14:50

jfagunde requested a review from a team as a code owner January 23, 2026 14:50

Copilot AI review requested due to automatic review settings January 23, 2026 14:50

Copilot started reviewing on behalf of jfagunde January 23, 2026 14:51 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

AampMPDParseHelper.cpp Outdated Show resolved Hide resolved

AampMPDParseHelper.cpp Outdated Show resolved Hide resolved

Apply suggestions from code review

307ab0b

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings January 23, 2026 15:53

Copilot started reviewing on behalf of jfagunde January 23, 2026 15:53 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

VPLAY-11600 IsEmptyPeriod() with checkIframe=false when using AAMP TSB #725

Are you sure you want to change the base?

VPLAY-11600 IsEmptyPeriod() with checkIframe=false when using AAMP TSB #725

Uh oh!

Conversation

jfagunde commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI commented Jan 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jfagunde commented Dec 3, 2025 •

edited

Loading