Skip to content

[WIP] WIP Address feedback on HTTP/1.1 Chunked Transfer support #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 20 commits into
base: dev_sprint_25_2
Choose a base branch
from
Draft

[WIP] WIP Address feedback on HTTP/1.1 Chunked Transfer support #824

Copilot wants to merge 20 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Jan 7, 2026 •
edited
Loading

Comprehensive Unit Tests for HTTP/1.1 Chunked Transfer Encoding Parser

Plan

  • Create test file for chunked_write_callback functionality
  • Add test fixture with mock CurlCallbackContext setup
  • Test valid chunk sequences
    • Single chunk with data
    • Multiple chunks
    • Zero-size terminating chunk
    • Large chunk sizes
  • Test edge cases
    • Partial data at callback boundaries
    • Chunk size split across callbacks
    • Chunk data split across callbacks
    • Delimiters split across callbacks
  • Test invalid input handling
    • Malformed chunk size (invalid hex)
    • Missing CR delimiter
    • Missing LF delimiter
    • Incorrect byte count
  • Test state transitions
    • All valid state transitions
    • Error state handling
  • Test chunk extensions (RFC 7230)
    • Chunk extensions after size
    • Extensions split across callbacks
  • Run tests and validate coverage

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

pstroffolino and others added 20 commits June 11, 2025 02:45
@pstroffolino
VPLAY-9694 optimize LLD to leverage http 1.1 chunked transfer mode
964f0f1 
Reason for change: leverage chunked transfer node to infer mdat boundaries
Test Procedure: new compile-time option
Risks: Medium

Signed-off-by: Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino @shripadgithub
VPLAY-9694 optimize LLD to leverage http 1.1 chunked transfer mode
a0cc491 
Reason for change: leverage chunked transfer node to infer mdat boundaries
Test Procedure: new compile-time option
Risks: Medium

Signed-off-by: Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino @shripadgithub
new code to collect HTTP/1.1 raw respose data and validate it
27c5a25
@pstroffolino @shripadgithub
VPLAY-9694 optimize LLD to leverage http 1.1 chunked transfer mode
d34787d 
Reason for change: leverage chunked transfer node to infer mdat boundaries
Test Procedure: new compile-time option
Risks: Medium

Signed-off-by: Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino @shripadgithub
VPLAY-9694 optimize LLD to leverage http 1.1 chunked transfer mode
c2c47f8 
Reason for change: leverage chunked transfer node to infer mdat boundaries
Test Procedure: new compile-time option
Risks: Medium

Signed-off-by: Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino @shripadgithub
new code to collect HTTP/1.1 raw respose data and validate it
6f0340b
@shripadgithub
Merge branch 'feature/VPLAY-9694_2' of https://github.com/rdkcentral/…
e36ae70 
…aamp into feature/VPLAY-9694_2
@pstroffolino
VPLAY-9694: chunked transfer mode test code
5188fd1 
Reason for change: reproduction of bad state

Test Procedure: see ticket

Priority: P2

Risks:Low (for test only; not necessarily planning to advance)

Signed-off-by: Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
VPLAY-9816 chunked transfer
60c423e 
Reason for change: bug fix
Test Procedure: stability test (no asserts)
Risks: Low
@pstroffolino
VPLAY-9694 chunked transfer protocol
d40f9aa 
Reason for change: disable by default
Test Procedure: regression only
Risks: Low
@pstroffolino
Merge branch 'dev_sprint_25_2' into feature/VPLAY-9694_2
72efdf4
@pstroffolino
Merge branch 'dev_sprint_25_2' into feature/VPLAY-9694_2
f02137f
@pstroffolino
Reason for Change: test code and assert removal
81a9d84 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Reason for Change: runtime config for debugging chunked transfer prot…
96386b6 
…ocol

Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Apply suggestions from code review
f1a0d88 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pstroffolino
Update priv_aamp.cpp
4428de4 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pstroffolino
Reason for Change: improved documentation
f4549ae 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Merge branch 'feature/VPLAY-9694_2' of https://github.com/rdkcentral/…
0d69e41 
…aamp into feature/VPLAY-9694_2
@pstroffolino
Reason for Change: compilation warnings, logging corrections
204e43c 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
Initial plan
2e38c73
Copilot AI mentioned this pull request Jan 7, 2026
Merged
Copilot AI requested a review from pstroffolino January 7, 2026 18:47
Base automatically changed from feature/VPLAY-9694_2 to dev_sprint_25_2 January 8, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstroffolino pstroffolino Awaiting requested review from pstroffolino

At least 1 approving review is required to merge this pull request.

Assignees

@pstroffolino pstroffolino

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pstroffolino @shripadgithub