Fix integer overflow in PSSH box KID count validation #831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses potential integer overflow in
ParseProtectionSystemSpecificHeaderBoxwherekidCount * 16multiplication could wrap around, bypassing bounds checks and causing buffer overruns with malformed MP4 files.Changes:
kidCount * 16multiplication<cstdint>forSIZE_MAXconstantWithout this check, a malicious
kidCountvalue (e.g.,SIZE_MAX / 16 + 1) would overflow to a small value, pass the subsequent bounds check at line 404, but advanceptrincorrectly at line 410.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.