Confirm bounds check for standard box size in MP4Demux #833
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review comment requested verification that the bounds check for
size < 8was present in the MP4 demuxer to prevent integer underflow when calculating box boundaries.Status
The bounds check is already in place as of commit 789a87e. No changes required.
The check validates
size >= 8before the subtraction, preventing underflow when corrupted MP4 data contains invalid box sizes.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.