Skip to content

[WIP] WIP address feedback on mp4demux hardening from PR #830 review #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 14 commits into
base: dev_sprint_25_2
Choose a base branch
from
Draft

[WIP] WIP address feedback on mp4demux hardening from PR #830 review #835

Copilot wants to merge 14 commits into from
+1,288 −161

Conversation

Copy link
Contributor

Copilot AI commented Jan 12, 2026 •
edited
Loading

Plan to address tenc box layout parsing feedback

  • Analyze current ParseTrackEncryptionBox logic
  • Refactor to make standard/fallback layout distinction clearer
  • Ensure bounds checks are properly structured
  • Add code comments explaining the two layout formats
  • Test the changes
  • Run code review

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

pstroffolino and others added 14 commits January 10, 2026 12:35
@pstroffolino
VPLAY-12333 mp4demux hardening
8867965 
Reason for Change: bounds checks and support for 64 bit size

Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Reason for Change: AC-4 support
562b881 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Reason for Change: few additional optimizations/improvements
789a87e 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Reason for Change: setParseError cleanup
7309613 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Merge branch 'dev_sprint_25_2' into feature/VPLAY-12333
1137d11
@pstroffolino
Reason for Change: fix for ac-4 parsing
7250d01 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Merge branch 'dev_sprint_25_2' into feature/VPLAY-12333
dfb2427
@pstroffolino
Readon for Change: more copilot nitpicks
6d80135 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Merge branch 'feature/VPLAY-12333' of https://github.com/rdkcentral/aamp
0cf5294 
 into feature/VPLAY-12333
@pstroffolino
Reason for Change: beefed up tests
b008810 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Reason for Change: added support for 'skip' box (same behavior as "free"
1762ff5 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Reason for Change: removed no-longer needed hack from utest
107adc9 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
@pstroffolino
Reason for Change: edge case fix
74227ca 
Signed-off-by: Philip Stroffolino <philip_stroffolino@cable.comcast.com>
Initial plan
f05001f
Copilot AI mentioned this pull request Jan 12, 2026
Merged
Copilot AI requested a review from pstroffolino January 12, 2026 01:06
Base automatically changed from feature/VPLAY-12333 to dev_sprint_25_2 January 12, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstroffolino pstroffolino Awaiting requested review from pstroffolino

At least 1 approving review is required to merge this pull request.

Assignees

@pstroffolino pstroffolino

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pstroffolino