VPLAY-12164 Http 404 for mpd while channel change by sayanurag · Pull Request #845 · rdkcentral/aamp

sayanurag · 2026-01-13T10:12:43Z

Reason for change: Moving the Teardown operation before the mpd update release cause some delay and results in more Http 404 errors.
Test Procedure: updated in ticket
Risks: Low

Copilot

Pull request overview

This PR addresses HTTP 404 errors occurring during channel changes by moving the MPD downloader release operation to happen immediately after stream abstraction deletion, rather than waiting for the complete Stop() sequence to finish.

Changes:

Added conditional MPD downloader release inside TeardownStream() when disableDownloads is true
The early release prevents unnecessary MPD update requests that would fail with HTTP 404 during channel transitions

priv_aamp.cpp

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

priv_aamp.cpp

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

priv_aamp.cpp

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Copilot · 2026-02-27T18:13:41Z

AampMPDDownloader.h

+	/**
+	*	@fn SetFogTsbDeleted
+	*	@brief Function to Set if Fog TSB is deleted
+	*/
+	void SetFogTsbDeleted(bool bDeleted) {mFogTsbDeleted = bDeleted;}
+


New public API SetFogTsbDeleted() and the new early-exit behavior in the download loop should have unit coverage (e.g., ensure setting the flag causes the downloader thread to stop requesting MPDs / exits promptly). There are existing AampMPDDownloader functional tests, so extending them here will help prevent regressions.

AampMPDDownloader.cpp

priv_aamp.cpp

AampMPDDownloader.h

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Copilot · 2026-02-27T18:34:43Z

AampMPDDownloader.cpp

+				if(mFogTsbDeleted)
+				{
+					//TODO: Deprecate when Fog tsb is removed. Ignore the manifest request from AAMP after the TSB deleted in fog when the stop called.
+					AAMPLOG_INFO("Fog tsb deleted. Ignoring MPD request and exiting");
+					break;
+				}


The flag check at line 399 lacks mutex protection. While this flag is being added to prevent unnecessary downloads after TSB deletion, accessing it without synchronization creates a race condition with the setter in PrivateInstanceAAMP::Stop().

There are two approaches to fix this:

If the flag is changed to std::atomic_bool (as recommended in the header file comment), use .load() here: if(mFogTsbDeleted.load())

Alternatively, check this flag within the existing mutex-protected section (lines 357-372) where mReleaseCalled is checked, since both serve similar purposes of terminating the download loop gracefully.

Copilot · 2026-02-27T18:34:43Z

AampMPDDownloader.h

+	*	@fn SetFogTsbDeleted
+	*	@brief Function to Set if Fog TSB is deleted
+	*/
+	void SetFogTsbDeleted(bool bDeleted) {mFogTsbDeleted = bDeleted;}


There is a mismatch between the method name declared here (SetFogTsbDeleted) and how it's called in priv_aamp.cpp:8365 (SetTsbDeleted). This will cause a compilation error because the method names don't match.

The declaration should be renamed to match the call site, or vice versa. Based on the pattern in the codebase and the fact that "Fog" is implementation-specific, SetTsbDeleted seems like the more appropriate name.

Suggested change

* @fn SetFogTsbDeleted

* @brief Function to Set if Fog TSB is deleted

*/

void SetFogTsbDeleted(bool bDeleted) {mFogTsbDeleted = bDeleted;}

* @fn SetTsbDeleted

* @brief Function to set if TSB is deleted

*/

void SetTsbDeleted(bool bDeleted) { mFogTsbDeleted = bDeleted; }

Copilot · 2026-02-27T18:34:43Z

AampMPDDownloader.cpp

+				if(mFogTsbDeleted)
+				{
+					//TODO: Deprecate when Fog tsb is removed. Ignore the manifest request from AAMP after the TSB deleted in fog when the stop called.
+					AAMPLOG_INFO("Fog tsb deleted. Ignoring MPD request and exiting");
+					break;
+				}


The new SetTsbDeleted method and the flag check logic in downloadMPDThread1() lack test coverage. Given that this functionality addresses a critical issue (HTTP 404 errors during channel changes), it should have unit tests to verify:

That setting the flag prevents subsequent MPD download attempts in the download thread

That the flag is properly initialized to false

Thread safety of the flag access (if implemented with atomic operations)

The existing test suite in test/utests/tests/AampMPDDownloader/FunctionalTests.cpp provides a good foundation for adding these tests.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Copilot · 2026-02-27T18:44:45Z

AampMPDDownloader.cpp

+				if(mFogTsbDeleted.load())
+				{
+					//TODO: Depecrate when Fog tsb is removed. Ignore the manifest request from AAMP after the TSB deleted in fog when the stop called.
+					AAMPLOG_INFO("Fog tsb deleted. Ignoring MPD request and exiting");
+					break;
+				}


Missing test coverage: The new functionality for setting and checking the Fog TSB deletion flag lacks test coverage. Given that the test suite has comprehensive tests for AampMPDDownloader (see test/utests/tests/AampMPDDownloader/FunctionalTests.cpp), new behavior should be covered. Consider adding a test that verifies the download loop exits correctly when mFogTsbDeleted is set to true.

Copilot · 2026-02-27T18:44:46Z

AampMPDDownloader.cpp

 	mCheckedLLDData(false),mMPDNotifierMtx(),mMPDNotifierCondVar(),mManifestRefreshCount(0),mIsLowLatency(false),
 	mMPDDnldDataMtx(),mMPDDnldDataCondVar()
-	,mLLDashData(),mCurrentposDeltaToManifestEnd(-1),mPublishTime(0),mMinimalRefreshRetryCount(0),mMPDNotifyPending(false)
+	,mLLDashData(),mCurrentposDeltaToManifestEnd(-1),mPublishTime(0),mMinimalRefreshRetryCount(0),mMPDNotifyPending(false),mFogTsbDeleted(false)


The fake implementation of AampMPDDownloader in test/utests/fakes/FakeAampMPDDownloader.cpp needs to be updated to include the new mFogTsbDeleted member in its constructor initializer list to match the production code. This inconsistency could cause issues in tests that depend on the fake implementation.

Copilot · 2026-02-27T18:44:46Z

priv_aamp.cpp

+		if(mMPDDownloaderInstance != nullptr)
+		{
+			mMPDDownloaderInstance->SetTsbDeleted(true);
+		}


Potential race condition: The SetTsbDeleted(true) call sets the atomic flag, but there's no synchronization to ensure the download thread has seen this flag before the TSB deletion proceeds. While std::atomic provides memory ordering guarantees, consider whether additional synchronization (e.g., waiting for the download thread to acknowledge the flag) is needed to ensure no HTTP 404 errors occur if the download thread is in the middle of processing a request when the TSB is deleted.

AampMPDDownloader.h

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

AampMPDDownloader.cpp

priv_aamp.cpp

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Reason for change: MPD requested to fog through downloadMPDThread1 even after deleting the fog tsb from PrivateInstanceAAMP::Stop(). It results in HTTP 404 error during fast channel change. This change will avoid the MPD request if the Fog TSB is deleted. Test Procedure: updated in ticket Risks: Low Signed-off-by: Anurag Krishnan <akrish513@cable.comcast.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-03T13:01:09Z

AampMPDDownloader.cpp

 			{
+				if(mFogTsbDeleted.load())
+				{
+					//TODO: Deprecate when Fog tsb is removed. Ignore the manifest request from AAMP after the TSB deleted in fog when the stop called.


Breaking out of the download loop when mFogTsbDeleted is set exits the downloader thread without setting mReleaseCalled. Since IsDownloaderDisabled() is based on mReleaseCalled, this can leave the downloader appearing “active” while no thread is running, and (combined with the flag not being reset) can also block future tunes. Consider treating this path as a release/stop signal (set mReleaseCalled and wake any waits), and ensure the flag is cleared as part of normal Initialize()/Start() for the next tune.

Suggested change

//TODO: Deprecate when Fog tsb is removed. Ignore the manifest request from AAMP after the TSB deleted in fog when the stop called.

//TODO: Deprecate when Fog tsb is removed. Ignore the manifest request from AAMP after the TSB deleted in fog when the stop called.

{

std::lock_guard<std::recursive_mutex> lock(mMPDDnldMutex);

mReleaseCalled = true;

}

Copilot AI review requested due to automatic review settings January 13, 2026 10:12

sayanurag requested a review from a team as a code owner January 13, 2026 10:12

Copilot started reviewing on behalf of sayanurag January 13, 2026 10:13 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

priv_aamp.cpp Outdated Show resolved Hide resolved

priv_aamp.cpp Outdated Show resolved Hide resolved

jfagunde reviewed Jan 13, 2026

View reviewed changes

priv_aamp.cpp Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings January 20, 2026 11:08

Copilot started reviewing on behalf of sayanurag January 20, 2026 11:08 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

priv_aamp.cpp Outdated Show resolved Hide resolved

priv_aamp.cpp Outdated Show resolved Hide resolved

priv_aamp.cpp Outdated Show resolved Hide resolved

sayanurag force-pushed the feature/VPLAY-12164_http-404 branch from 6098e5f to 62d4beb Compare January 20, 2026 11:16

Copilot AI review requested due to automatic review settings January 21, 2026 20:48

Copilot started reviewing on behalf of pstroffolino January 21, 2026 20:49 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

priv_aamp.cpp Outdated Show resolved Hide resolved

priv_aamp.cpp Outdated Show resolved Hide resolved

priv_aamp.cpp Outdated Show resolved Hide resolved

sayanurag force-pushed the feature/VPLAY-12164_http-404 branch from 42b9a38 to d1bcc85 Compare February 27, 2026 14:11

Copilot AI review requested due to automatic review settings February 27, 2026 18:10

sayanurag force-pushed the feature/VPLAY-12164_http-404 branch from d1bcc85 to 0c0ac9c Compare February 27, 2026 18:10

Copilot started reviewing on behalf of sayanurag February 27, 2026 18:10 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 27, 2026 18:30

Copilot started reviewing on behalf of sayanurag February 27, 2026 18:31 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

sayanurag force-pushed the feature/VPLAY-12164_http-404 branch from 9085e19 to 7db7319 Compare February 27, 2026 18:39

sayanurag requested a review from Copilot February 27, 2026 18:41

Copilot started reviewing on behalf of sayanurag February 27, 2026 18:41 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

sayanurag force-pushed the feature/VPLAY-12164_http-404 branch from 7db7319 to 313f366 Compare March 2, 2026 13:13

sayanurag requested a review from Copilot March 2, 2026 13:13

Copilot started reviewing on behalf of sayanurag March 2, 2026 13:14 View session

sayanurag force-pushed the feature/VPLAY-12164_http-404 branch from 313f366 to 7f30bba Compare March 2, 2026 13:15

Copilot AI reviewed Mar 2, 2026

View reviewed changes

AampMPDDownloader.cpp Show resolved Hide resolved

priv_aamp.cpp Show resolved Hide resolved

sayanurag requested a review from Copilot March 2, 2026 13:50

Copilot started reviewing on behalf of sayanurag March 2, 2026 13:50 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

sayanurag force-pushed the feature/VPLAY-12164_http-404 branch from 7f30bba to aef3b23 Compare March 2, 2026 14:36

Copilot AI review requested due to automatic review settings March 2, 2026 16:20

sayanurag force-pushed the feature/VPLAY-12164_http-404 branch from aef3b23 to 5647483 Compare March 2, 2026 16:20

Copilot started reviewing on behalf of sayanurag March 2, 2026 16:20 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

sayanurag requested a review from Copilot March 3, 2026 12:57

Copilot started reviewing on behalf of sayanurag March 3, 2026 12:57 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Conversation

sayanurag commented Jan 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!