Revert "Revert "RDK-60157 : unified support for SetAC4Tracks"" #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request re-introduces unified support for AC4 (audio codec) track selection by reverting a previous revert. The change refactors the SetAC4Tracks method from a pure virtual function requiring platform-specific implementations to a virtual function with a default implementation in the base SocInterface class.
Changes:
- Moved
SetAC4Tracksimplementation from platform-specific classes to the baseSocInterfaceclass - Changed
SetAC4Tracksfrom pure virtual (= 0) to virtual with default implementation - Added platform-specific override in
DefaultSocInterfacewith conditional compilation for macOS/Ubuntu
Reviewed changes
Copilot reviewed 1 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| middleware/vendor/SocInterface.h | Changed SetAC4Tracks from pure virtual to virtual with implementation |
| middleware/vendor/SocInterface.cpp | Added default SetAC4Tracks implementation with null checks and logging |
| middleware/vendor/default/DefaultSocInterface.h | Declared SetAC4Tracks override (without override keyword) |
| middleware/vendor/default/DefaultSocInterface.cpp | Implemented platform-specific version with conditional compilation |
| middleware/vendor/realtek/RealtekSocInterface.h | Removed platform-specific SetAC4Tracks override |
| middleware/vendor/realtek/RealtekSocInterface.cpp | Removed Realtek-specific implementation |
| middleware/vendor/amlogic/AmlogicSocInterface.h | Removed platform-specific SetAC4Tracks override |
| middleware/vendor/amlogic/AmlogicSocInterface.cpp | Removed Amlogic-specific implementation |
| middleware/vendor/brcm/BrcmSocInterface.h | Removed inline no-op implementation |
| middleware/test/utests/fakes/FakeSocInterface.cpp | Removed fake override (now uses base implementation) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #856
Preparing for reintroduction