RDKEMW-11912 Prevent AAMP from FFWD when at live #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpc005
reviewed
Jan 21, 2026
cpc005
approved these changes
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent AAMP from attempting fast-forward (FFWD) operations when playback is already at the live edge, which was causing GStreamer state-related issues on some platforms. The fix modifies the logic in SetRateInternal() to add an early-exit check for this condition.
Changes:
- Simplified the live point check condition to prevent rate changes >= 1.0 when at live edge
- Added a no-op call to
IsStreamerAtLivePoint()(line 750) with unclear intent - Removed blank line for minor formatting cleanup
jfagunde
reviewed
Jan 21, 2026
Use static_cast for IsStreamerAtLivePoint call
Updated comment to clarify the condition for clearing the flag.
jfagunde
reviewed
Jan 21, 2026
dnfaulkner
reviewed
Jan 21, 2026
dnfaulkner
reviewed
Jan 21, 2026
dnfaulkner
left a comment
dnfaulkner
left a comment
There was a problem hiding this comment.
Not a biggy and does not need to be addressed. Just thought I'd comment ;)
19 tasks
Contributor
Co-authored-by: DomSyna <[email protected]>
Co-authored-by: DomSyna <[email protected]>
Contributor
Co-authored-by: DomSyna <[email protected]>
Contributor
This was referenced Jan 21, 2026
Contributor
Contributor
Contributor
…eAAMP Co-authored-by: DomSyna <[email protected]>
Co-authored-by: DomSyna <[email protected]>
Fix mock delegation for IsLiveStream and IsAtLivePoint in FakePrivateInstanceAAMP
Fix Doxygen parameter formatting in SetIsAtLivePoint documentation
Co-authored-by: Copilot <[email protected]>
Contributor
…o-live-black-screen
…o-live-black-screen
…o-live-black-screen
jfagunde
reviewed
Jan 23, 2026
jfagunde
reviewed
Jan 23, 2026
test/utests/tests/PlayerInstanceAAMP/PlayerInstanceAAMPTestsMain.cpp
Outdated
Show resolved
Hide resolved
test/utests/tests/PlayerInstanceAAMP/PlayerInstanceAAMPTestsMain.cpp
Outdated
Show resolved
Hide resolved
test/utests/tests/PlayerInstanceAAMP/PlayerInstanceAAMPTestsMain.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When actioning trick modes there is no point in moving to FFWD when currently playing at the live edge. If we do this causes issues on some platforms when we attempt to perform a gstreamer seek and gstreamer is not in the correct state to receive the command.
The change fixes the logic in SetRateInternal() to prevent FFWD rate changes when at the live edge