-
Notifications
You must be signed in to change notification settings - Fork 8
VPLAY-12213: ABR Refactoring part 3 - encapsulate remaining abr logic #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| /* | ||
| * If not stated otherwise in this file or this component's license file the | ||
| * following copyright and licenses apply: | ||
| * | ||
| * Copyright 2026 RDK Management | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| #ifndef AAMP_ABR_BANDWIDTH_ESTIMATOR_BASE_H | ||
| #define AAMP_ABR_BANDWIDTH_ESTIMATOR_BASE_H | ||
|
|
||
| #include <cstddef> | ||
|
|
||
| #include "AampMediaType.h" | ||
|
|
||
| #define DEFAULT_ABR_CHUNK_CACHE_LENGTH 10 /**< Default ABR chunk cache length */ | ||
|
|
||
| /** | ||
| * @brief Plain Old Data (POD) structure for profiling information from a | ||
| * given CURL instance. | ||
| */ | ||
| struct DownloadMetrics | ||
| { | ||
| std::size_t m_size_download_bytes; // CURLINFO_SIZE_DOWNLOAD | ||
| double m_total_time_seconds; // CURLINFO_TOTAL_TIME | ||
| double m_time_to_first_byte_seconds; // CURLINFO_STARTTRANSFER_TIME | ||
| }; | ||
|
|
||
| /** | ||
| * @brief POD structure for in-flight progress updates (xferinfo-style). | ||
| */ | ||
| struct DownloadProgressInfo | ||
| { | ||
| double m_now_seconds; | ||
| std::size_t m_total_bytes; | ||
| std::size_t m_now_bytes; | ||
| }; | ||
|
|
||
| /** | ||
| * @brief Optional configuration for bandwidth estimators. | ||
| * | ||
| * Not all estimators use every field. Estimators that do not support | ||
| * configuration should ignore it. | ||
| */ | ||
| struct BandwidthEstimatorConfig | ||
| { | ||
| int mAbrCacheLife; | ||
| int mAbrCacheLength; | ||
| int mAbrCacheOutlier; | ||
| std::size_t mLowLatencyCacheLength; | ||
|
|
||
| /** | ||
| * @brief Default constructor. | ||
| */ | ||
| BandwidthEstimatorConfig() | ||
| : mAbrCacheLife(0), | ||
| mAbrCacheLength(0), | ||
| mAbrCacheOutlier(0), | ||
| mLowLatencyCacheLength(0) | ||
| { | ||
| } | ||
|
|
||
| /** | ||
| * @brief Parameterized constructor. | ||
| */ | ||
| BandwidthEstimatorConfig( | ||
| int abrCacheLife, | ||
| int abrCacheLength, | ||
| int abrCacheOutlier, | ||
| std::size_t lowLatencyCacheLength) | ||
| : mAbrCacheLife(abrCacheLife), | ||
| mAbrCacheLength(abrCacheLength), | ||
| mAbrCacheOutlier(abrCacheOutlier), | ||
| mLowLatencyCacheLength(lowLatencyCacheLength) | ||
| { | ||
| } | ||
| }; | ||
|
|
||
| /** | ||
| * @brief Base interface for bandwidth estimation algorithms. | ||
| */ | ||
| class BandwidthEstimatorBase | ||
| { | ||
| public: | ||
| virtual ~BandwidthEstimatorBase() {} | ||
|
|
||
| /** | ||
| * @brief Human-readable algorithm name. | ||
| */ | ||
| virtual const char* GetNetworkEstimatorName() const = 0; | ||
|
|
||
| /** | ||
| * @brief Reset all internal state. | ||
| */ | ||
| virtual void Reset() = 0; | ||
|
|
||
| /** | ||
| * @brief Add a bandwidth sample (bits per second). | ||
| */ | ||
| virtual void AddBandwidthSample(BitsPerSecond downloadbps, bool lowLatencyMode) = 0; | ||
|
|
||
| /** | ||
| * @brief Add download metrics derived from curl (optional). | ||
| */ | ||
| virtual void UpdateDownloadMetrics(const DownloadMetrics &metrics ) = 0; | ||
|
|
||
| /** | ||
| * @brief Provide in-flight download progress updates (optional). | ||
| */ | ||
| virtual void UpdateDownloadProgress(const DownloadProgressInfo &progressInfo) | ||
| { | ||
| } | ||
|
|
||
| /** | ||
| * @brief Update estimator configuration (optional). | ||
| * | ||
| * Default implementation is a no-op. | ||
| */ | ||
| virtual void SetConfig(const BandwidthEstimatorConfig &config) | ||
| { | ||
| } | ||
|
|
||
| /** | ||
| * @brief Return current bandwidth estimate (bits per second). | ||
| * | ||
| * @return Estimated bandwidth in bits per second, or -1 if unavailable. | ||
| */ | ||
| virtual BitsPerSecond GetBandwidthBitsPerSecond() = 0; | ||
|
|
||
| /** | ||
| * @brief Return current robust throughput estimate (bytes/s). | ||
| */ | ||
| virtual double GetThroughputBytesPerSecond() = 0; | ||
|
|
||
| /** | ||
| * @brief Return current overhead (TTFB) estimate (seconds). | ||
| */ | ||
| virtual double GetTimeToFirstByteSeconds() = 0; | ||
|
|
||
| /** | ||
| * @brief Predict download completion time for a segment. | ||
| * | ||
| * Predicts how long it will take (wall-clock time) to download a | ||
| * segment of the given size using the estimator's current state. | ||
| * | ||
| * Units: | ||
| * - @p segment_size_bytes: bytes | ||
| * - return value: seconds | ||
| * | ||
| * Semantics: | ||
| * - Implementations may include protocol/connection overhead (e.g. | ||
| * time-to-first-byte) in addition to payload transfer time. | ||
| * - If there is insufficient data to estimate bandwidth, or the | ||
| * estimate is not usable (e.g. <= 0), implementations should return | ||
| * 0.0 to indicate "unavailable". | ||
| */ | ||
| virtual double GetPredictedDownloadTimeSeconds(std::size_t segment_size_bytes) = 0; | ||
|
|
||
| /** | ||
| * @brief Reset only the currently available bandwidth estimate. | ||
| */ | ||
| virtual void ResetCurrentlyAvailableBandwidth() | ||
| { | ||
| } | ||
| }; | ||
|
|
||
| #endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include "abr.h"appears unused in this translation unit (no ABRManager/BANDWIDTH symbols referenced). Removing it would avoid an unnecessary dependency and reduce rebuild impact when ABR headers change.