Skip to content

Conversation

@Gnanesha
Copy link
Contributor

VPLAY-12061:Closed captioning issues after introducing webvTT along with inBand CC tracks

Reason for change: filter out the webvtt tracks before sending the list of tracks to application
Test Procedure: see ticket
Risks: Low

…ith inBand CC tracks

Reason for change: filter out the webvtt tracks before sending the list of tracks to application
Test Procedure: see ticket
Risks: Low

Signed-off-by: Gnanesha <gnaani82@gmail.com>
Copilot AI review requested due to automatic review settings January 24, 2026 19:05
@Gnanesha Gnanesha requested a review from a team as a code owner January 24, 2026 19:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configuration flag to disable WebVTT subtitle tracks so that only in-band closed caption (CC) tracks are exposed to applications, addressing mixed WebVTT/in-band CC behavior.

Changes:

  • Introduced a new boolean config eAAMPConfig_DisableWebVTT (key disableWebVTT) with default false.
  • Updated PrivateInstanceAAMP::Tune to automatically enable disableWebVTT for the “peacock” app by default.
  • Updated PrivateInstanceAAMP::GetAvailableTextTracks to filter out non-CC (WebVTT) tracks when disableWebVTT is set, and added a unit test intended to verify that only CC tracks are returned.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
priv_aamp.cpp Uses eAAMPConfig_DisableWebVTT in GetAvailableTextTracks to restrict the returned list to CC-only when enabled, and configures disableWebVTT by default for the Peacock app in Tune.
AampConfig.h Adds the eAAMPConfig_DisableWebVTT enum entry to the boolean config list.
AampConfig.cpp Registers the new disableWebVTT boolean setting in the boolean config lookup table with default false.
test/utests/tests/PrivateInstanceAAMP/ClosedCaptionTests.cpp Adds a new unit test targeting the disableWebVTT behavior for GetAvailableTextTracks (though current expectations still assume all tracks are serialized).

@rdkcentral rdkcentral deleted a comment from Copilot AI Jan 24, 2026
@rdkcentral rdkcentral deleted a comment from Copilot AI Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants