VPLAY-12203: - Subtitles Fails to display after Ad break point on VOD… #908
+5
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… asset on perform FF till the ad break point Reason for Change: fix inband CC resume from ad to content and content to ad Test Guidance: Check the ticket Risk: Low Signed-off-by: Gnanesha <gnaani82@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes in-band closed captions (subtitles) not resuming correctly when transitioning between ad and main content (e.g., FF to an ad break on VOD).
Changes:
- Removes the earlier pre-teardown capture of the CC enabled state in
TuneHelper(). - Adds a later capture/log of
previousCCEnabledbefore sink configuration, intended to support CC restoration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPLAY-12203: - Subtitles Fails to display after Ad break point on VOD asset on perform FF till the ad break point
Reason for Change: fix inband CC resume from ad to content and content to ad
Test Guidance: Check the ticket
Risk: Low