Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #385
The
width
/Height
properties are always withoutmargin
. Basicalycontent
+padding
+border
.The
result
variable here however needs to calculate the outer bounds of space consumed, which includesmargin
.This is also stated in the lines directly above, where
MBPWith
andMBPHeight
is added.The statements below override the resulting dimensions, but totaly forget to add the
margin
, which this PR fixes.Code example:
Before this PR:
With this PR: