Skip to content

Conversation

@Bamboy
Copy link
Contributor

@Bamboy Bamboy commented Oct 2, 2025

This PR improves the FileDialog class:

Restructured the way "place" and "drive" directories are queried from the system, to be OS independent:

  • On Linux, drives are queried from the system using bash lsblk command.
  • Mac is still using the old (windows) way of "places/drives" - I did not add Mac/OSX support.
  • "Places" under the user's HOME folder are now adjustable per-OS. (Not configurable)
  • Added user Documents, Pictures directories.
  • Added support to override the "places/drives" widget-list creation at a few different points.

Crashing will still occur if you navigate to a directory the app doesn't have permissions for.
This is untested on anything other than my Linux system.

@Bamboy
Copy link
Contributor Author

Bamboy commented Oct 2, 2025

Screenshot_20251001_193745

Above image with changes, from my linux system (MyraPad)

Some notes:

  • INITDISK R5 is a USB stick. Others are internal hard drive partitions.
  • sdc2 is my main OS filesystem mounted at /home. It has no LABEL on the system, hence why no name in the UI.
  • [Home] bamboy directs to /home/bamboy - I thought this looked better next to the other display elements. (The behavior I worked around would have been displaying as /home/bamboy)
    ...
  • Changed [Brackets] instead of (Parenthesis) around VolumeLabel, applies all OS. Understandable if this is undesirable.

@rds1983 rds1983 merged commit be6993d into rds1983:master Oct 3, 2025
1 check passed
@rds1983
Copy link
Owner

rds1983 commented Oct 3, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants