Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactoring to Function Component #514

Merged
merged 64 commits into from
Nov 28, 2023
Merged

refactor: refactoring to Function Component #514

merged 64 commits into from
Nov 28, 2023

Conversation

Wxh16144
Copy link
Contributor

@Wxh16144 Wxh16144 commented Mar 5, 2023

No description provided.

@vercel
Copy link

vercel bot commented Mar 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ❌ Failed (Inspect) Nov 28, 2023 6:20am

@Wxh16144 Wxh16144 mentioned this pull request Mar 5, 2023
Open
13 tasks
@afc163
Copy link
Member

afc163 commented May 24, 2023

还在搞么

@Wxh16144
Copy link
Contributor Author

还在搞么

嗯, 搞的

crazyair
crazyair reviewed Nov 1, 2023
View reviewed changes
src/Pagination.tsx Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

zombieJ commented Nov 1, 2023

其实可以直接改或者加个不提交的文件备份，改名 deprecated 的话很容易冲突

@Wxh16144
Copy link
Contributor Author

Ready~，随时 review

@MadCcc
Copy link
Member

MadCcc commented Nov 20, 2023

image
看看补下

@Wxh16144
Copy link
Contributor Author

看看补下

看了一下详情，感觉可以不用 care ，不过我会尽量尝试补充一下

@Wxh16144

This comment was marked as outdated.

Sign in to view
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023

Deployment failed with the following error:

Resource is limited - try again in 11 minutes (more than 100, code: "api-deployments-free-per-day").

MadCcc
MadCcc reviewed Nov 28, 2023
View reviewed changes
jest.config.js Outdated Show resolved Hide resolved
@MadCcc
Copy link
Member

MadCcc commented Nov 28, 2023

这个 PR 可以合了，再开一个 PR 迁移 enzyme 到 testing library

@MadCcc MadCcc merged commit f5ac698 into react-component:master Nov 28, 2023
8 of 9 checks passed
@afc163
Copy link
Member

afc163 commented Nov 28, 2023

https://github.com/react-component/pagination/releases/tag/v4.0.0

@li-jia-nan
Copy link
Member

antd 侧是不是还需要更新一下版本号？

This was referenced Nov 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jia-nan li-jia-nan li-jia-nan left review comments

@crazyair crazyair crazyair left review comments

@MadCcc MadCcc MadCcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Wxh16144 @afc163 @zombieJ @MadCcc @li-jia-nan @crazyair