-
-
Notifications
You must be signed in to change notification settings - Fork 323
fix: onHover is not a function #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough此次更改涉及 Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #870 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 64 64
Lines 2711 2712 +1
Branches 758 759 +1
=======================================
+ Hits 2587 2588 +1
Misses 121 121
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/PickerPanel/TimePanel/TimePanelBody/index.tsx (1 hunks)
Additional comments not posted (1)
src/PickerPanel/TimePanel/TimePanelBody/index.tsx (1)
29-37
: 确保onHover
函数的默认值为
onHover
函数添加默认值() => {}
确保即使未提供onHover
函数,组件也能正常工作。这增强了组件的健壮性,防止了运行时错误。代码更改已批准。
close #869
Summary by CodeRabbit
TimePanelBody
组件添加了onHover
函数的默认值,增强了组件的健壮性,避免了因未定义的onHover
函数而导致的运行时错误。