Skip to content

Fix ticketing by moving off web hook interaction handling #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

vcarl
Copy link
Member

@vcarl vcarl commented Dec 12, 2024

This is really how this should have been done in the first place but I didn't want to have to figure out how to more gracefully allow for multiple commands to be exported from a single file, cuz I didn't want to be required to put all the different button/modal/etc logic in separate files.

Copy link

what-the-diff bot commented Dec 12, 2024

PR Summary

  • Ticket Setup Refactoring:
    The code responsible for setting up tickets was streamlined. This includes the removal of unneeded pieces and the grouping of interactive handling commands into a more organized system. Now, interacting with the software, such as commands and messages, is handled in a more uniform way.

  • Command Registration Improvement:
    The process of registering commands was improved in the 'deployCommands.server.ts' file, allowing for more versatile management of different types of commands. A new function called 'matchCommand' was also introduced.

  • Addition of Interaction Type Checks:
    Our software's interaction handling was enhanced. It can now recognize not only slash commands but also component messages and modal interactions.

  • Command Data Structure Simplification:
    The command structure was simplified to a single type - 'AnyCommand'. This simplification makes it easier to manage interactions based on their type.

  • 'index.ts' Update:
    The registration calls in the 'index.ts' file were adjusted to match the new command structure. Any unnecessary parameters were removed.

  • Groundwork for Additional Interactions:
    This update paves the way for the addition of more types of interactions in the future. It does this by introducing an improved organization and management of commands.

@vcarl vcarl merged commit b7f34d7 into main Dec 12, 2024
5 checks passed
@vcarl vcarl deleted the vc-fix-ticketing-commands branch December 12, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant