Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add early return to thread enforcement #360

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add early return to thread enforcement #360

merged 1 commit into from
Mar 19, 2024

Conversation

vcarl
Copy link
Member

@vcarl vcarl commented Mar 19, 2024

No description provided.

@vcarl vcarl merged commit 4b3f04b into main Mar 19, 2024
3 checks passed
@vcarl vcarl deleted the vc-hotfix branch March 19, 2024 16:54
@vcarl
Copy link
Member Author

vcarl commented Mar 19, 2024

I think what might have happened is, thread messages started coming through on more parts of the API? We started getting a new error message on the 11th, but it's not super clear how this is related to the change in behavior

image

Okay yeah this looks to have been incorrectly running through all the "should a thread be created" logic on messages sent in threads. It blew up on startThread because it's "not in a guild text channel" (it's in a thread)

So it would leave regular messages alone, but deleted replies because they're processed earlier and have an early return

It's possible that "onMessage" wasn't receiving all thread messages before or something, but it's a little weird that it ever worked correctly tbh. Seems like it should always have had this behavior 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant