Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reatibot-report-vc-bot-messages-to-separate-channel #365

Conversation

mattmattvanvoorst
Copy link
Contributor

Rework logger into a Map, so we can identify loggers better.

Our logger now logs into a specific channel (and the default logger). This allows us to more granularly log into specific channels.

VC specific message are now logged into a separate channel, to declutter the bot-log

Rework logger into a Map, so we can identify loggers better.

Our logger now logs into a specific channel (and the default logger). This allows us to more granularly log into specific channels.

VC specific message are now logged into a separate channel, to declutter the bot-log
Copy link

what-the-diff bot commented May 6, 2024

PR Summary

  • Improved Software Development Practices
    A minor update has been added to the .gitignore file. This will help keep the code repository clean by ignoring certain files that aren't necessary for overall project function (like .idea).

  • Contribution Guideline Update
    The CONTRIBUTING.md file has been updated to guide contributors to first install and test the bot on the Reactiflux Test Server instead of the live Reactiflux Server. This helps to prevent possible interruptions to the live service while testing new updates.

  • Development Dependency Addition
    The @types/node-cron has been added to the devDependencies in the project's package-lock.json file. This will ensure developers have the correct tools and packages to work on this codebase.

  • Extended Log Storage
    The vcLog constant has been added to the CHANNELS object in channels.ts, signifying that our logs are now saved in an additional location.

  • Logging Improvement in Voice-Activity
    Code in the voice-activity.ts file has been updated to include more extensive logging features, allowing for more in-depth monitoring and debugging of the voice activity feature.

  • Enhanced Logging in Main Index
    The main index.ts file now has enhanced logging features as well, ramping up our overall ability to monitor application activity and troubleshoot any issues.

@vcarl
Copy link
Member

vcarl commented May 6, 2024

5.083 [warn] Code style issues found in the above file(s). Forgot to run Prettier?

:doge:

package-lock.json Outdated Show resolved Hide resolved
src/constants/channels.ts Outdated Show resolved Hide resolved
Copy link
Member

@vcarl vcarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but yea the formatting enforcement is complaining

#11 3.977 [warn] src/constants/channels.ts
#11 4.555 [warn] src/features/log.ts
#11 4.663 [warn] src/features/voice-activity.ts
#11 4.898 [warn] src/index.ts
#11 4.935 [warn] Code style issues found in the above file(s). Forgot to run Prettier?

@mattmattvanvoorst
Copy link
Contributor Author

I cant make heads or tails of that error in the Docker step. I need an adult

@vcarl
Copy link
Member

vcarl commented May 7, 2024

Yup I know that one. I never got it set up right to correctly work for forks, so that error is expected. I should make an issue for it, I thought there already was one

Copy link
Member

@vcarl vcarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge at your leisure! lgtm

@mattmattvanvoorst mattmattvanvoorst merged commit 726556c into reactiflux:main May 7, 2024
2 of 3 checks passed
@mattmattvanvoorst mattmattvanvoorst deleted the reatibot-report-vc-bot-messages-to-separate-channel branch May 7, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants