-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reatibot-report-vc-bot-messages-to-separate-channel #365
reatibot-report-vc-bot-messages-to-separate-channel #365
Conversation
Rework logger into a Map, so we can identify loggers better. Our logger now logs into a specific channel (and the default logger). This allows us to more granularly log into specific channels. VC specific message are now logged into a separate channel, to declutter the bot-log
PR Summary
|
Variable name change
:doge: |
Co-authored-by: Carl Vitullo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but yea the formatting enforcement is complaining
#11 3.977 [warn] src/constants/channels.ts
#11 4.555 [warn] src/features/log.ts
#11 4.663 [warn] src/features/voice-activity.ts
#11 4.898 [warn] src/index.ts
#11 4.935 [warn] Code style issues found in the above file(s). Forgot to run Prettier?
I feel a lot prettier
I cant make heads or tails of that error in the Docker step. I need an adult |
Yup I know that one. I never got it set up right to correctly work for forks, so that error is expected. I should make an issue for it, I thought there already was one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge at your leisure! lgtm
Rework logger into a Map, so we can identify loggers better.
Our logger now logs into a specific channel (and the default logger). This allows us to more granularly log into specific channels.
VC specific message are now logged into a separate channel, to declutter the bot-log