Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate reactpy.html.* elements #1255

Merged
merged 7 commits into from
Jan 26, 2025

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 26, 2025

Description

With ReactPy's previous design of the reactpy.html module, we need to manually write every single HTML element that could exist. This is not efficient and is fairly annoying to maintain.

This PR updates reactpy.html to auto-generate HTML nodes that are unknown, leading to a better user experience.

Common HTML elements are typed out as attribute stubs strictly for IDE auto-completion purposes.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger linked an issue Jan 26, 2025 that may be closed by this pull request
@Archmonger Archmonger linked an issue Jan 26, 2025 that may be closed by this pull request
@Archmonger Archmonger marked this pull request as ready for review January 26, 2025 06:00
@Archmonger Archmonger merged commit 754dc11 into reactive-python:main Jan 26, 2025
17 checks passed
@Archmonger Archmonger deleted the v2.0-new-html-interface branch January 26, 2025 06:05
@Archmonger Archmonger changed the title Auto-generate unknown HTML nodes Auto-generate reactpy.html.* elements Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix starlette example for 'running reactpy' docs New interface for reactpy.html
1 participant