Fix nullable annotations for OneWayBind #4010
Merged
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elem-74
force-pushed
the
fixOneWayBindAnnotations
branch
from
d983fb7 to
12b2467
Compare
ChrisPulman
previously approved these changes
Apr 14, 2025
|
Please check the tests all pass. Thank you. |
elem-74
force-pushed
the
fixOneWayBindAnnotations
branch
from
3836c01 to
47ed078
Compare
elem-74
force-pushed
the
fixOneWayBindAnnotations
branch
from
47ed078 to
2715d5f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4010 +/- ##
==========================================
+ Coverage 59.03% 63.23% +4.20%
==========================================
Files 160 137 -23
Lines 5847 5193 -654
Branches 1031 785 -246
==========================================
- Hits 3452 3284 -168
+ Misses 2007 1703 -304
+ Partials 388 206 -182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It should be better now even though it seems the .editorconfig made my commit add a newline at the end of the .txt files |
ChrisPulman
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes nullable annotations for OneWayBind
What is the current behavior?
#4009
What is the new behavior?
When the object you select is nullable, there is a warning for dereferencing it without nullcheck. If the object is not nullable, there is no warning.
What might this PR break?
Not sure, I'm not that familiar with the codebase, but I don't see what it could break.
Please check if the PR fulfills these requirements
Other information:
Let me know if I should improve the PR in any way.