Skip to content

Translation of state a components memory #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rohhan415
Copy link
Contributor

Translation of 'State and a Component’s Memory' for the Polish docs

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
pl-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 2:18pm

@dawidsabat
Copy link
Collaborator

@Rohhan415, I have finished my review. In general, very good work! Keep it up! 🚀
Only minor mistakes, nothing serious. A have added couple of suggestions too 😉

@Rohhan415
Copy link
Contributor Author

@dawidsabat Thank you for your feedback! Unfortunately, I don’t see the suggested changes. Since this is my first PR, I might be missing something, but I also don’t see any submitted reviews. Could you check if the review was submitted?

Copy link
Collaborator

@dawidsabat dawidsabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ready.

@dawidsabat
Copy link
Collaborator

@Rohhan415, my bad. Check now 😉

@Rohhan415
Copy link
Contributor Author

@dawidsabat All suggested changes have been implemented. I hope I didn't miss anything this time. :)

Copy link
Collaborator

@dawidsabat dawidsabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We can merge it.
I hope you didn’t accept my comments without questioning them. I can make mistakes as well 😉

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@dawidsabat dawidsabat merged commit 29bb573 into reactjs:main Mar 26, 2025
5 checks passed
@Rohhan415 Rohhan415 deleted the translation-of-state-a-components-memory branch March 27, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants