Learn / Referencing Values with Refs #511
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
piotr-pajak
force-pushed
the
piotr-pajak/learn_referencing-values-with-refs
branch
from
9c7a5f3 to
4c78e8d
Compare
Thanks for the extensive feedback! I missed quite a few things, especially regarding the impersonal form of verbs. Your feedback also answers many of the questions that I had during the translation process. I'll apply the feedback in the next few days and will mention you once the changes have been implemented. I also have a quick question about resolving conversations: what's the preferred approach on this repository? Should the reviewer resolve them, or the person who implements the fixes 🤔? |
|
That's the spirit! 🔥 I am not aware of any specific way of working in this project regarding resolving conversations, but I would say that if you simply agree with suggestion or fix is very simple and it can be done in one way only, you can apply it and resolve. I think this will be 95% of cases. You can left conversation open in rare cases when change can be done in couple of ways and you are not sure how it will be received by the reviewer. |
|
Hey @dawidsabat, |
piotr-pajak
force-pushed
the
piotr-pajak/learn_referencing-values-with-refs
branch
from
c97c11f to
4bdcd85
Compare
piotr-pajak
force-pushed
the
piotr-pajak/learn_referencing-values-with-refs
branch
from
4bdcd85 to
2b9c3a5
Compare
Great! I will review it tomorrow. |
piotr-pajak
force-pushed
the
piotr-pajak/learn_referencing-values-with-refs
branch
from
2b9c3a5 to
734df38
Compare
piotr-pajak
force-pushed
the
piotr-pajak/learn_referencing-values-with-refs
branch
from
734df38 to
3af8233
Compare
Translation of the page Learn / Escape Hatches / Referencing Values with Refs into 🇵🇱 .
Note
This is my first translation, any feedback or suggestions for improvement would be greatly appreciated 😉