Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(zh-hant): Translate Hello World #4

Merged
merged 4 commits into from
Feb 15, 2019
Merged

docs(zh-hant): Translate Hello World #4

merged 4 commits into from
Feb 15, 2019

Conversation

JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented Feb 10, 2019 •
edited
Loading

This Pull Request translates Hello World - React page.

How to preview

git clone [email protected]:reactjs/zh-hant.reactjs.org.git
git am -3 https://github.com/reactjs/zh-hant.reactjs.org/pull/4
yarn dev 
(new tab)
open http://localhost:8000/docs/hello-world.html
Click to view translated page from this Pull Request

localhost_8000_docs_hello-world html

Reference

See the tracking issue of progress: #1

neighborhood999
neighborhood999 reviewed Feb 11, 2019
View reviewed changes
@neighborhood999
Apply suggestions
7131bb2 
Co-authored-by: Peng Jie <[email protected]>
@tesseralis tesseralis mentioned this pull request Feb 12, 2019
Closed
92 tasks
itszero
itszero reviewed Feb 12, 2019
View reviewed changes
Copy link
Contributor

@itszero itszero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I have some nits here!

@JuanitoFatas
Copy link
Contributor Author

@chloewlin @bugtender pinging for review 🙇‍♀️

bugtender
bugtender reviewed Feb 15, 2019
View reviewed changes
Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍Just a minor issue.
We want to keep every component words stay lowercase. 🙏Thank you.

@neighborhood999
Copy link
Member

@JuanitoFatas Thank you for your translate.

@neighborhood999 neighborhood999 merged commit bfc06b6 into reactjs:master Feb 15, 2019
@JuanitoFatas JuanitoFatas deleted the zh-hant/hello-world branch February 15, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itszero itszero itszero left review comments

@bugtender bugtender bugtender left review comments

@neighborhood999 neighborhood999 neighborhood999 left review comments

Assignees
No one assigned
Labels
Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuanitoFatas @neighborhood999 @itszero @bugtender