Skip to content

Repeat specification for use with repeatWhen operator #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

kwondh5217
Copy link
Contributor

Description

This PR addresses #3545.

This introduces RepeatSpec into core, aligning with the structure of Retry, without modifying the existing repeatWhen or Mono#repeatWhen method signatures.

The implementation brings over the functionality of repeat from reactor-addons, allowing users to configure repeat behavior through static factory methods like times(...), create(...), and once().

Result

Closes gh-3545

@kwondh5217 kwondh5217 requested a review from a team as a code owner May 9, 2025 19:56
@kwondh5217 kwondh5217 marked this pull request as draft May 10, 2025 04:39
@chemicL chemicL marked this pull request as ready for review July 2, 2025 08:45
@chemicL chemicL added the type/enhancement A general enhancement label Jul 2, 2025
@chemicL chemicL added this to the 3.8.0-M5 milestone Jul 2, 2025
@chemicL
Copy link
Member

chemicL commented Jul 2, 2025

@kwondh5217 thanks, this looks very promising. I intend to merge the PR as is, follow up with a cleanup for some things I noticed when reviewing. I think this is a good basis for deprecating the Repeat functionality in reactor-addons. It would be great to follow up with the missing features, but we can also do it on demand.

@kwondh5217
Copy link
Contributor Author

@chemicL, Appreciate the review! Glad to hear it’s a good starting point.
Let me know if you’d like help with the follow-up cleanup or adding missing features.
I’d be happy to contribute further.

@chemicL chemicL merged commit c6574a1 into reactor:main Jul 2, 2025
9 checks passed
chemicL added a commit that referenced this pull request Jul 2, 2025
Merged RepeatSpec with Repeat to avoid exposing package private
RepeatSignal. Also, removed explicit contextWrite which is unnecessary
when there is no onErrorStop used like with Retry companion.

Fixes #3545

Signed-off-by: Dariusz Jędrzejczyk <[email protected]>
@chemicL
Copy link
Member

chemicL commented Jul 2, 2025

@kwondh5217 please review my changes from b313f57.

Thank you for your contribution! 🎉

@kwondh5217
Copy link
Contributor Author

Thanks @chemicL!
b313f57 looks great. thanks for the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeat specification for use with repeatWhen operator
2 participants