Skip to content

Fix: SinksTest > OptimisticEmitFailureHandlerTest > shouldRetryOptimistically flaky test #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix: SinksTest > OptimisticEmitFailureHandlerTest > shouldRetryOptimistically flaky test #4036

merged 1 commit into from
Jul 7, 2025

Conversation

georgebanasios
Copy link
Contributor

@georgebanasios georgebanasios commented Jun 14, 2025 •
edited
Loading

Fixes #3773
SinksTest > OptimisticEmitFailureHandlerTest > shouldRetryOptimistically flaky test

@georgebanasios georgebanasios requested a review from a team as a code owner June 14, 2025 05:44
@chemicL chemicL added type/test/flaky type/test A change in test sources labels Jun 30, 2025
@chemicL
Copy link
Member

chemicL commented Jun 30, 2025

Thanks, this looks great! Do you mind re-applying the change on top of 3.7.x branch and changing the PR to have 3.7.x as the target?

@georgebanasios georgebanasios force-pushed the fix-should-retry-optimistically-flaky-test branch from f832741 to be8267b Compare June 30, 2025 11:37
@georgebanasios georgebanasios changed the base branch from main to 3.7.x June 30, 2025 11:38
@georgebanasios georgebanasios force-pushed the fix-should-retry-optimistically-flaky-test branch from be8267b to f832741 Compare June 30, 2025 11:41
@georgebanasios georgebanasios changed the base branch from 3.7.x to main June 30, 2025 11:41
@georgebanasios georgebanasios force-pushed the fix-should-retry-optimistically-flaky-test branch from f832741 to 4c80932 Compare June 30, 2025 12:05
@georgebanasios georgebanasios changed the base branch from main to 3.7.x June 30, 2025 12:05
@georgebanasios
Copy link
Contributor Author

georgebanasios commented Jun 30, 2025 •
edited
Loading

@chemicL Yes of course. I think it's done!

chemicL
chemicL approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chemicL chemicL merged commit 23d4de5 into reactor:3.7.x Jul 7, 2025
9 checks passed
chemicL added a commit that referenced this pull request Jul 7, 2025
@chemicL
Merge #4036 into 3.8.0-M5
0869aad 
Signed-off-by: Dariusz Jędrzejczyk <[email protected]>
@chemicL chemicL added this to the 3.7.8 milestone Jul 7, 2025
@chemicL chemicL mentioned this pull request Jul 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemicL chemicL chemicL approved these changes

Assignees
No one assigned
Labels
type/test/flaky type/test A change in test sources
Projects
None yet
Milestone
3.7.8
Development

Successfully merging this pull request may close these issues.

[Flaky test] SinksTest > OptimisticEmitFailureHandlerTest > shouldRetryOptimistically() FAILED
2 participants
@georgebanasios @chemicL