Fix: Sinks queue is not cleared on immediate cancellation #4056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3359
This PR resolves an issue where elements buffered in a
Sinks.many().unicast().onBackpressureBuffer()
orSinks.many().multicast().onBackpressureBuffer()
sink were not discarded if the downstream consumer cancelled immediately, most notably through operators like.take(0)
.Root cause:
The
.take(0)
operator creates aFluxLimitRequest
instance, which is anOptimizableOperator
.During the subscription phase, the
subscribeOrReturn
is getting called on this operator before propagating the subscription to the upstream source (SinkManyUnicast).Because the take limit is 0,
FluxLimitRequest
immediately completes the downstream subscriber and returns null. This null return signals that the subscription chain should be terminated.As a result,
subscribe()
is never called on the SinkManyUnicast. The sink is left unaware that a consumer ever attempted to connect and its cancellation and cleanup logic, which would clear the buffer, is never triggered.Solution:
The affected Sinks implement the
SourceProducer
interface and override a method that provides an opt-in side-channel for operators to signal a source to release its resources, bypassing the standard subscription path.