Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAPPS-DB] Adding missing icons for Audio, Video, Graphics and 15 Gaming apps. #240

Merged
merged 16 commits into from
Sep 2, 2024

Conversation

Gathub22
Copy link
Contributor

@Gathub22 Gathub22 commented May 13, 2024

I'm adding missing icons to existing apps to improve readability and overall RAPPS' appearance.

I only add icons designed to the app itself or their developers' icons. I'm trying to make all icons transparent so in case the RAPPS' theme changes, it doesn't have ugly white backgrounds. Also I'm trying to add the exact icons that were used at the time these applications were released. Ofc those icons are completely owned by their respective owners, not by me in any way.

I'm adding icons based on these guidelines:

  1. The icon is used to represent the game itself or its developers.
  2. The icon is used to represent the software itself and not its origin. For example, if the software is a PC port of an old Nintendo game, I won't add the original logo of that ancient game to RAPPS. Only if the port has its own.
  3. The icon should be the closest to the one that relates to the version of the software. For example, it would be really innacurate to use Microsoft's 2012 logo to represent a Windows XP application.
  4. The icon will be 100x100 px.
  5. The icon will be fully transparent.

There is an ongoing Jira issue to discuss about this problem.

I'm open for any suggestions or help :)

Completed categories

  • Audio 🎵
  • Video 🎬
  • Graphics 🖌️
  • Games and fun 🕹️ (15 new icons)

In total 32 new icons have been added to this PR.

In future PRs

  • Internet and network 🌐
  • Office 🖊️
  • Development 🦺
  • Edutainment 📚
  • Engineering ⚙️
  • Finance 💰
  • Science 🧪
  • Tools 🔧
  • Drivers 💿
  • Libraries 📦
  • Themes 🎨
  • Other 🗃️

Comparison

Before

1

After

2

Added Fox AP, jetAudio, Xiph codecs, Pulseaudio and Spotify icons
Added GrafX2, Irfanview, LibreCAD and Photivo
Added Photofiltre, Scribus and TuxPaint
Added AssaultCube, Balloon Fight, Bos Wars and Cave Story
Added Bound Around demo, Christmas Bound and Chicken Invaders
Added BSU, Stalin, Tux Racer, Gens and Globulation2
@learn-more
Copy link
Member

@Gathub22 what is the status of this PR?

@Gathub22
Copy link
Contributor Author

@learn-more Bc of lack of time its stuck. However we could split this PR and prepare merging whats already done

@learn-more
Copy link
Member

@learn-more Bc of lack of time its stuck. However we could split this PR and prepare merging whats already done

That seems like the way forward.

@Gathub22 Gathub22 changed the title [RAPPS-DB] Adding missing icons [RAPPS-DB] Adding missing icons for Audio, Video, Graphics and 15 Gaming apps. Aug 23, 2024
@Gathub22 Gathub22 marked this pull request as ready for review August 23, 2024 11:38
Added master's translations next to my icons
GrafX2.txt Outdated Show resolved Hide resolved
@julenuri julenuri self-assigned this Sep 2, 2024
@julenuri
Copy link
Collaborator

julenuri commented Sep 2, 2024

I will check locally, and if everything works nicely, I will commit it. 😄

icons/ballonfight.ico Outdated Show resolved Hide resolved
@julenuri julenuri merged commit 6a23c3f into reactos:master Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants