-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAPPS-DB] Adding missing icons for Audio, Video, Graphics and 15 Gaming apps. #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Fox AP, jetAudio, Xiph codecs, Pulseaudio and Spotify icons
Added GrafX2, Irfanview, LibreCAD and Photivo
Added Photofiltre, Scribus and TuxPaint
Added AssaultCube, Balloon Fight, Bos Wars and Cave Story
Added Bound Around demo, Christmas Bound and Chicken Invaders
Added BSU, Stalin, Tux Racer, Gens and Globulation2
@Gathub22 what is the status of this PR? |
@learn-more Bc of lack of time its stuck. However we could split this PR and prepare merging whats already done |
That seems like the way forward. |
Gathub22
changed the title
[RAPPS-DB] Adding missing icons
[RAPPS-DB] Adding missing icons for Audio, Video, Graphics and 15 Gaming apps.
Aug 23, 2024
Added master's translations next to my icons
learn-more
reviewed
Aug 27, 2024
learn-more
approved these changes
Aug 30, 2024
I will check locally, and if everything works nicely, I will commit it. 😄 |
julenuri
requested changes
Sep 2, 2024
Prepare to be ready to merge.
julenuri
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding missing icons to existing apps to improve readability and overall RAPPS' appearance.
I only add icons designed to the app itself or their developers' icons. I'm trying to make all icons transparent so in case the RAPPS' theme changes, it doesn't have ugly white backgrounds. Also I'm trying to add the exact icons that were used at the time these applications were released. Ofc those icons are completely owned by their respective owners, not by me in any way.
I'm adding icons based on these guidelines:
There is an ongoing Jira issue to discuss about this problem.
I'm open for any suggestions or help :)
Completed categories
In total 32 new icons have been added to this PR.
In future PRs
Comparison
Before
After