-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAPPS-DB] Add Realtek multiple audio drivers #278
Conversation
Please add more details into the PRs description about the "few tweaks" that are currently still necessary to make them work. |
RealtekHD.txt
Outdated
Name = Realtek HD Audio Drivers R2.74 (WDM) | ||
Version = R2.74 (5.10.0.7111) | ||
License = Propietary | ||
Description = Realtek HD Audio codec and drivers, suitable for multiple soundcards/chipsets and devices as workstation, laptops, minipc, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional suggestion. Notice the part with the EOL-whitespace-stripping. That part is mandatory.
Description = Realtek HD Audio codec and drivers, suitable for multiple soundcards/chipsets and devices as workstation, laptops, minipc, etc. | |
Description = Realtek HD Audio codec and drivers, suitable for multiple soundcards/chipsets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add turkish description
use that
[Section.041f]
Description =
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved already, Despite the 3 remaining whitespace nits.
Co-authored-by: Joachim Henze <[email protected]>
URLSite = https://www.realtek.com/ | ||
URLDownload = https://akacc.net/win98/0001-WDM_A406.exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the URLSite links to the specified download URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we can't have a functional download link from the Realtek Website because it needs a captcha and a tocken every single time you try to download the drivers. So... In that side, we are a bit "blocked" to access the original source, we need that alternative or some "webarchive" link.
URLSite = https://www.realtek.com/ | ||
URLDownload = https://ftp.nluug.nl/pub/games/PC/guru3d/realtek/WDM_R274-[Guru3D.com].exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the URLSite links to the specified download URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto from the AC97.
All of them (realtek hd and ac97) are partially compatible to our code, and will fasten up the testing in case that the user wants to test them.
With few tweaks the thing works nicely.
AC97: Tweak quoted under CORE-18238
HDAUD: Tweak quoted under CORE-17310
Examples: Portcls.sys from windows 2003 https://www.youtube.com/watch?v=EsU7WNkpuF8
And
https://www.youtube.com/watch?v=-NukhxCScic with some hdaudbus tweaks.
I hope this will speedup our tests. 💯