Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles not in 'zh' and not in 'zh_Latn_pinyin' will be returned #483

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

whalekeykeeper
Copy link
Contributor

Modified the first SQL query in ci.yml.

See #456

Another question:
if W0414 is skipped because the related titles are unknown,
then it seems that other ids should be skipped, too.
See picture:
Screen Shot 2021-08-18 at 2 02 23 AM

@duncdrum
Copy link
Member

yes good point, this is a leftover, each table PS, SS, AW has an entry for unknown, i think we should basically limit that to two unknown art work and text. But before we'll do that we ll have to make sure that the entries can be merged. For now filtering all unknown is a good idea.

@duncdrum duncdrum merged commit b5f50ff into master Aug 18, 2021
@duncdrum duncdrum deleted the fix_sql_for_view branch August 18, 2021 07:30
@whalekeykeeper whalekeykeeper restored the fix_sql_for_view branch September 18, 2021 19:10
@duncdrum duncdrum deleted the fix_sql_for_view branch September 21, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants