Skip to content

Commit

Permalink
feat: support node 18
Browse files Browse the repository at this point in the history
  • Loading branch information
erunion committed May 3, 2022
1 parent 802d58a commit 9d769c7
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 13 deletions.
21 changes: 10 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@ on: [push]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version:
- 14
- 16
- 18

steps:
- uses: actions/checkout@v3
Expand All @@ -19,13 +21,10 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

# Node 16 ships with npm@8 so for compatibility reasons we're upping this for everything else.
- name: Install npm@8
if: matrix.node-version != '16.x'
run: npm install -g npm@8

- name: Install dependencies
run: npm ci
# Node 14 ships with npm@6 which doesn't install peerDeps by default.
- name: Install npm@7
if: matrix.node-version == '14'
run: npm install -g npm@7

- name: Run tests
run: npm test
- run: npm ci
- run: npm test
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"author": "Jon Ursenbach <[email protected]>",
"license": "MIT",
"engines": {
"node": "^12 || ^14 || ^16"
"node": ">=14"
},
"dependencies": {
"@types/har-format": "^1.2.8",
Expand Down

0 comments on commit 9d769c7

Please sign in to comment.