feat(php): upgrade PHP support and dependencies #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiAndreiev
changed the title
erunion
reviewed
Aug 29, 2024
| @@ -16,7 +16,8 @@ RUN apk add php81 \ | |||
| php81-simplexml \ | |||
| php81-tokenizer \ | |||
| php81-xml \ | |||
| php81-xmlwriter | |||
| php81-xmlwriter \ | |||
| php81-pdo | |||
There was a problem hiding this comment.
mind moving this after php81-phar so this list stays alphabetical?
Comment on lines
+24
to
+25
| "phpoption/phpoption": "^1.9", | ||
| "vlucas/phpdotenv": "^5.6" |
There was a problem hiding this comment.
There were some errors on the new versions:
Uncaught Error: Call to undefined method Dotenv\Repository\RepositoryBuilder::create
Error: Class "PhpOption\Option" not found
And this installed packages seems to fix them.
gratcliff
approved these changes
Sep 16, 2024
|
@AndriiAndreiev do you mind resolving conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Laravel 11.x requires a minimum PHP version of 8.2, so there is no CI action for Laravel 11 with PHP 8.1
Some of the updated packages required code changes (there were failing tests and failed static analysis (+ taint) checks