Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python/fastapi): prefix path capturing #1198

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Conversation

AndriiAndreiev
Copy link
Collaborator

@AndriiAndreiev AndriiAndreiev commented Mar 18, 2025

🧰 Changes

Fix prefix path not captured issue.
We had a problem with FastAPI integration that the Middleware did not captured the path for each request and sent only β€œ/” instead.

🧬 QA & Testing

Try sending a few test requests with paths, for example, β€œ/hello/world”. Now it should not be empty.

@AndriiAndreiev AndriiAndreiev marked this pull request as ready for review March 18, 2025 15:34
@teunis90
Copy link

@AndriiAndreiev, @roszkodenys asked me to test your PR.
I've tested it on our FastAPI repository with many router objects.

I can confirm that this PR works:

CleanShot 2025-03-19 at 20 19 35

@AndriiAndreiev AndriiAndreiev merged commit 3a2a0db into main Mar 20, 2025
43 checks passed
@AndriiAndreiev AndriiAndreiev deleted the fix/fastapi-routing branch March 20, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants