[wip] reproduce CL status failure on parallelism

when paralleling steps, the steps share a key and uuid. this is insufficient to distinguish parallelized steps. so if one step fails and another succeeds, the gerrit status update step does not recognize the failure. DO NOT MERGE! Change-Id: Ib13b614a311a79542ee5389c834929c9791ff0bc
readysettech · Jan 9, 2025 · bcc0999 · bcc0999
1 parent 27b1f0d
commit bcc0999
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 150 deletions.
diff --git a/.buildkite/pipeline.public-common.yml b/.buildkite/pipeline.public-common.yml
@@ -11,160 +11,12 @@ common_values:
         limit: 3
 steps:
 
-  - label: ':rust: Check rustfmt'
-    key: check-rustfmt
-    commands:
-      - '[ -d public ] && cd public'
-      - "cargo --locked fmt -- --check"
-    depends_on:
-    - build-image
-    plugins:
-      - docker#v3.8.0:
-          image: '305232526136.dkr.ecr.us-east-2.amazonaws.com/readyset-build:${BUILDKITE_COMMIT}'
-          volumes:
-          - 'target:/workdir/target'
-          environment:
-          - SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
-          - SCCACHE_REGION=us-east-2
-          - CARGO_INCREMENTAL=0
-          - RUST_BACKTRACE=full
-      - ecr#v2.7.0:
-          login: true
-          retries: 3
-    retry: *retry_on_agent_kill
-
-  - label: ':rust: :lock: Check cargo-deny'
-    commands:
-      - '[ -d public ] && cd public'
-      - export RUST_BACKTRACE=full
-      - cargo --locked deny check
-    depends_on:
-    - cargo-deny-image
-    plugins:
-      - docker#v3.8.0:
-          image: '305232526136.dkr.ecr.us-east-2.amazonaws.com/cargo-deny:${BUILDKITE_COMMIT}'
-          environment:
-          - SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
-          - SCCACHE_REGION=us-east-2
-          - CARGO_INCREMENTAL=0
-          - RUST_BACKTRACE=full
-      - ecr#v2.7.0:
-          login: true
-          retries: 3
-    retry: *retry_on_agent_kill
-
-  - label: ':clippy: Check clippy'
-    key: check-clippy
-    commands:
-      - '[ -d public ] && cd public'
-      - export RUST_BACKTRACE=full
-      - cargo --locked clippy --workspace --all-targets --all-features -- -D warnings
-    depends_on:
-    - build-image
-    plugins:
-      - docker#v3.8.0:
-          image: '305232526136.dkr.ecr.us-east-2.amazonaws.com/readyset-build:${BUILDKITE_COMMIT}'
-          volumes:
-          - 'target:/workdir/target'
-          environment:
-          - SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
-          - SCCACHE_REGION=us-east-2
-          - CARGO_INCREMENTAL=0
-          - RUST_BACKTRACE=full
-      - ecr#v2.7.0:
-          login: true
-          retries: 3
-    retry: *retry_on_agent_kill
-
   - label: ':rust: Run tests'
     key: rust-tests
     parallelism: 2
     commands:
-      - '[ -d public ] && cd public'
-      - '.buildkite/run-tests.sh'
+      - '.buildkite/run_retry_dummy.sh'
     timeout_in_minutes: 60
-    depends_on:
-    - build-image
-    plugins:
-      - docker-compose#v3.7.0:
-          run: app
-          env:
-          - BUILDKITE_PARALLEL_JOB
-          - SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
-          - SCCACHE_REGION=us-east-2
-          - CARGO_INCREMENTAL=0
-          - RUST_BACKTRACE=full
-          - MYSQL_HOST=mysql
-          - MYSQL_PWD=noria
-          - MYSQL_DB=noria
-          volumes:
-            - 'target:/workdir/target'
-          config:
-            - "${GIT_PUBLIC_ROOT}build/docker-compose.yml"
-            - "${GIT_PUBLIC_ROOT}build/docker-compose.ci-test.yml"
-          mount-buildkite-agent: true
-          pull-retries: 3
-      - ecr#v2.7.0:
-          login: true
-          retries: 3
     agents:
       queue: c6a-4xlarge
     retry: *retry_on_agent_kill
-
-  - label: 'Run logictest'
-    key: logictest
-    command:
-      - 'echo +++ Running readyset-logictest'
-      - '[ -d public ] && cd public'
-      - export RUST_BACKTRACE=full
-      - cargo --locked run --bin readyset-logictest -- verify logictests
-      - cargo --locked run --bin readyset-logictest -- verify logictests/psql --database-type postgresql
-      - cargo --locked run --bin readyset-logictest -- verify logictests/mysql --database-type mysql
-    timeout_in_minutes: 60
-    depends_on:
-    - build-image
-    plugins:
-      - docker-compose#v3.7.0:
-          run: app
-          env:
-          - SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
-          - SCCACHE_REGION=us-east-2
-          - CARGO_INCREMENTAL=0
-          - RUST_BACKTRACE=full
-          config:
-            - "${GIT_PUBLIC_ROOT}build/docker-compose.yml"
-            - "${GIT_PUBLIC_ROOT}build/docker-compose.ci-test.yml"
-          pull-retries: 3
-      - ecr#v2.7.0:
-          login: true
-          retries: 3
-    retry: *retry_on_agent_kill
-
-  - label: 'Test benchmark framework'
-    key: test-benchmark
-    command:
-      - '[ -d public ] && cd public'
-      - 'echo +++ Running benchmarks'
-      - export RUST_BACKTRACE=full
-      - cargo --locked run --bin benchmarks -- --local --database-type mysql --benchmark benchmarks/src/yaml/benchmarks/test/benchmark_test.yaml
-      - cargo --locked run --bin benchmarks -- --local-with-upstream mysql://root:noria@mysql/noria --database-type mysql --benchmark benchmarks/src/yaml/benchmarks/test/benchmark_test.yaml
-    timeout_in_minutes: 60
-    depends_on:
-    - build-image
-    plugins:
-      - docker-compose#v3.7.0:
-          image: '305232526136.dkr.ecr.us-east-2.amazonaws.com/readyset-build:${BUILDKITE_COMMIT}'
-          run: app
-          environment:
-          - SCCACHE_BUCKET=readysettech-build-sccache-us-east-2
-          - SCCACHE_REGION=us-east-2
-          - CARGO_INCREMENTAL=0
-          - RUST_BACKTRACE=full
-          config:
-            - "${GIT_PUBLIC_ROOT}build/docker-compose.yml"
-            - "${GIT_PUBLIC_ROOT}build/docker-compose.ci-test.yml"
-          pull-retries: 3
-      - ecr#v2.7.0:
-          login: true
-          retries: 3
-    retry: *retry_on_agent_kill
diff --git a/.buildkite/run-tests.sh b/.buildkite/run-tests.sh
@@ -18,12 +18,14 @@ export PROPTEST_MAX_SHRINK_TIME=1800000
 if [[ "$BUILDKITE_PARALLEL_JOB" == "0" ]]; then
     # Run nextest
     echo "+++ :rust: Run tests (nextest)"
+    exit 1
     cargo --locked nextest run --workspace \
         --ignore-default-filter --hide-progress-bar \
         --features failure_injection \
         --exclude readyset-clustertest --exclude benchmarks \
         || upload_artifacts
 elif [[ "$BUILDKITE_PARALLEL_JOB" == "1" ]]; then
+    exit 0
     # Run doctests, because at this time nextest does not support doctests
     echo "+++ :rust: Run tests (doctest)"
     cargo --locked test --workspace \

diff --git a/build/docker-compose.ci-test.yml b/build/docker-compose.ci-test.yml
@@ -24,7 +24,7 @@ services:
     expose:
       - '6379'
   app:
-    image: "305232526136.dkr.ecr.us-east-2.amazonaws.com/readyset-build:${BUILDKITE_COMMIT}"
+    image: "305232526136.dkr.ecr.us-east-2.amazonaws.com/readyset-build:latest"
     ulimits:
       nofile:
         soft: "65536"