add "launch on REANA" badge and launcher URL creator #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe-steduto
force-pushed
the
launch-on-reana-badge-creator
branch
3 times, most recently
from
f712d6a to
8bf640e
Compare
mdonadoni
reviewed
Nov 2, 2023
Comment on lines
9
to
27
| import { useState } from "react"; | ||
| import { | ||
| Button, | ||
| Form, | ||
| Input, | ||
| Grid, | ||
| Segment, | ||
| Divider, | ||
| Container, | ||
| Icon, | ||
| Popup, | ||
| } from "semantic-ui-react"; | ||
|
|
||
| import styles from "~/pages/badgeCreator/BadgeLaunchCreator.module.scss"; | ||
| import { CodeSnippet, Title } from "~/components"; | ||
| import { LAUNCH_ON_REANA_BADGE_URL } from "~/config"; | ||
| import BasePage from "~/pages/BasePage"; | ||
| import { triggerNotification } from "~/actions"; | ||
| import { useDispatch } from "react-redux"; |
There was a problem hiding this comment.
minor: maybe let's reorganize the imports a bit, at least by moving react-redux to the first part of the imports, and possibly also ordering them in alphabetical order?
(related to this: VSCode has an action to organize imports, and probably other editors have too. Maybe we should enforce import ordering somehow, both for python and js sources?)
There was a problem hiding this comment.
Maybe we can use this eslint plugin?
giuseppe-steduto
force-pushed
the
launch-on-reana-badge-creator
branch
3 times, most recently
from
0f06616 to
861a118
Compare
mdonadoni
reviewed
Nov 9, 2023
reana-ui/src/pages/badgeCreator/LauncherBadgeCreator.module.scss
Outdated
Show resolved
Hide resolved
giuseppe-steduto
force-pushed
the
launch-on-reana-badge-creator
branch
2 times, most recently
from
eb3d01e to
c4071ce
Compare
mdonadoni
approved these changes
Nov 16, 2023
Change the launch page so that the optional parameters are displayed in a table, where each row correspond to a parameter, and the value of each of them is displayed in its JSON-serialized version. This allows to correctly show even complex parameters like objects and lists.
giuseppe-steduto
force-pushed
the
launch-on-reana-badge-creator
branch
from
c4071ce to
aa77618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
launch: display parameters in table
Change the launch page so that the optional parameters are displayed
in a table, where each row correspond to a parameter, and the value of
each of them is displayed in its JSON-serialized version.
This allows to correctly show even complex parameters like objects and
lists.
launch: add launcher URL and badge creator page
client: fix no-anonymous-default-export linting warning
Closes #324.