Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): show jupyter badge only after the pod is running #416

Merged
merged 1 commit into from
Jan 16, 2025
+3 −3
Merged

fix(ui): show jupyter badge only after the pod is running #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reana-ui/src/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ export function openInteractiveSession(id, options = {}) {
"Success!",
"The interactive session has been created. " +
"However, it could take several minutes to start the Jupyter Notebook. " +
"Click on the Jupyter logo to access it. " +
"Click on the Jupyter notebook badge to access it. " +
`${interactiveSessionInactivityWarning}`,
),
);
Expand Down
2 changes: 1 addition & 1 deletion reana-ui/src/components/WorkflowActionsPopup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default function WorkflowActionsPopup({ workflow, className }) {
const isDeleted = status === "deleted";
const isDeletedUsingWorkspace = isDeleted && size.raw > 0;
const isRunning = status === "running";
const isSessionOpen = sessionStatus === "created";
const isSessionOpen = sessionStatus === "running";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍

BTW, now that we have a new design, we could amend the text "Click on the Jupyter logo to access it" to say something like "Click on the Jupyter notebook badge to access it."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetics: for the commit log, please use capital letter for Jupyter:

fix(ui): show Jupyter badge only after notebook is running (#416)


let menuItems = [];

Expand Down
2 changes: 1 addition & 1 deletion reana-ui/src/components/WorkflowBadges.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function WorkflowBadges({ workflow }) {
session_status: sessionStatus,
} = workflow;
const hasDiskUsage = size.raw > 0;
const isSessionOpen = sessionStatus === "created";
const isSessionOpen = sessionStatus === "running";

return (
<div className={styles.badgesContainer}>
Expand Down
Loading