feat(workflow-badges): add Dask dashboard icon #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana-ui
that referenced
this pull request
Jan 16, 2025
Alputer
force-pushed
the
dask-dashboard-badge
branch
from
3f4be6d to
72590f4
Compare
Alputer
added a commit
to Alputer/reana-ui
that referenced
this pull request
Jan 17, 2025
Alputer
force-pushed
the
dask-dashboard-badge
branch
from
72590f4 to
4ae2831
Compare
tiborsimko
reviewed
Jan 20, 2025
| @@ -64,6 +67,21 @@ export default function WorkflowBadges({ workflow }) { | |||
| rel="noopener noreferrer" | |||
| /> | |||
| )} | |||
| {isDaskClusterUp && ( | |||
There was a problem hiding this comment.
todo: Since the main functionality touches workflow badges, and since conventional commit scope should represent component touched by the change, please use feat(workflow-badges): add Dask dashboard badge.
(We haven't respected this fully in the past, so we have a lot of feat(ui), but it would be good to move to the "proper" scopes...)
Alputer
added a commit
to Alputer/reana-ui
that referenced
this pull request
Jan 20, 2025
Alputer
force-pushed
the
dask-dashboard-badge
branch
from
4ae2831 to
0b7de4d
Compare
Alputer
force-pushed
the
dask-dashboard-badge
branch
from
0b7de4d to
e4c024b
Compare
Alputer
changed the title
tiborsimko
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Dask dashboard badgewhich redirects users to Dask dashboard page upon click.