Skip to content

Conversation

@Alputer
Copy link
Member

@Alputer Alputer commented Apr 3, 2025

@mr-c
Copy link
Member

mr-c commented Apr 3, 2025

Shouldn't these be set automatically from the CWL ResourceRequirements.{cores,ram}Max?

@Alputer Alputer requested a review from tiborsimko April 3, 2025 09:28
@Alputer
Copy link
Member Author

Alputer commented Apr 3, 2025

Shouldn't these be set automatically from the CWL ResourceRequirements.{cores,ram}Max?

As you probably know, due to the multi-workflow-engine nature of REANA, we have a job controller that exposes the same API for all workflow engines and handles the actual dispatching itself. We can certainly parse the parameter you mentioned in reana-workflow-engine-cwl and pass it to the REANA job controller. However, to stay compatible with our kubernetes_memory_limit implementation, we chose to implement it this way. You can refer to the kubernetes_memory_limit implementation here:
https://docs.reana.io/advanced-usage/compute-backends/kubernetes/#custom-memory-limit

Alputer added a commit to Alputer/reana-workflow-engine-cwl that referenced this pull request Apr 4, 2025
@mr-c
Copy link
Member

mr-c commented Apr 4, 2025

We can certainly parse the parameter you mentioned in reana-workflow-engine-cwl and pass it to the REANA job controller.

Great, please let me know how I can help with that. The timeout option also duplicates a built-in CWL feature. https://www.commonwl.org/v1.2/CommandLineTool.html#ToolTimeLimit

Alputer added a commit to Alputer/reana-workflow-engine-cwl that referenced this pull request Apr 7, 2025
Alputer added a commit to Alputer/reana-workflow-engine-cwl that referenced this pull request Apr 7, 2025
@tiborsimko tiborsimko merged commit 2170e33 into reanahub:maint-0.9 Apr 7, 2025
12 checks passed
tiborsimko added a commit to tiborsimko/reana-workflow-engine-cwl that referenced this pull request Nov 27, 2025
ci(runners): upgrade CI runners to Ubuntu 22.04 (reanahub#294)
feat(cwl_reana): pass K8s requests/limits to job controller (reanahub#292)
tiborsimko added a commit to tiborsimko/reana-workflow-engine-cwl that referenced this pull request Nov 27, 2025
ci(runners): upgrade CI runners to Ubuntu 22.04 (reanahub#294)
feat(cwl_reana): pass K8s requests/limits to job controller (reanahub#292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants