-
Notifications
You must be signed in to change notification settings - Fork 41
feat(cwl_reana): pass resource requests/limits to job-controller #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Shouldn't these be set automatically from the CWL |
As you probably know, due to the multi-workflow-engine nature of REANA, we have a job controller that exposes the same API for all workflow engines and handles the actual dispatching itself. We can certainly parse the parameter you mentioned in reana-workflow-engine-cwl and pass it to the REANA job controller. However, to stay compatible with our kubernetes_memory_limit implementation, we chose to implement it this way. You can refer to the kubernetes_memory_limit implementation here: |
Great, please let me know how I can help with that. The timeout option also duplicates a built-in CWL feature. https://www.commonwl.org/v1.2/CommandLineTool.html#ToolTimeLimit |
7f22b04 to
2170e33
Compare
ci(runners): upgrade CI runners to Ubuntu 22.04 (reanahub#294) feat(cwl_reana): pass K8s requests/limits to job controller (reanahub#292)
ci(runners): upgrade CI runners to Ubuntu 22.04 (reanahub#294) feat(cwl_reana): pass K8s requests/limits to job controller (reanahub#292)
Closes reanahub/reana#883