Skip to content

feat: Add new PageHeader.LeadingElement component #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

kurtdoherty
Copy link
Contributor

Context

  • After PageHeader was implemented in v5 component refactor: PageHeader #490, Design made some updates regarding the leading element which require us to introduce a new PageHeader.LeadingElement.

This PR

  • Introduces a new PageHeader.LeadingElement subcomponent that helps size the leading element correctly based on its type: icon vs image.
  • Scouts some broken links in the change log.
Screenshot 2025-07-10 at 1 01 14 pm Screenshot 2025-07-10 at 12 52 49 pm

@rpt-uk-github
Copy link

rpt-uk-github commented Jul 10, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty force-pushed the feat-add-page-header-leading-element-component branch from e1dd9d5 to c3fc788 Compare July 10, 2025 03:01
Copy link

codacy-production bot commented Jul 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d7caa7a1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d7caa7a) Report Missing Report Missing Report Missing
Head commit (c3fc788) 7457 6737 90.34%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#607) 12 12 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty marked this pull request as ready for review July 10, 2025 03:19
@kurtdoherty kurtdoherty merged commit 0c1cdf2 into main Jul 10, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the feat-add-page-header-leading-element-component branch July 10, 2025 03:19
@kurtdoherty kurtdoherty linked an issue Jul 10, 2025 that may be closed by this pull request
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5 component refactor: PageHeader
2 participants