Skip to content

feat: Add new Dialog.Body #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

feat: Add new Dialog.Body #630

merged 1 commit into from
Jul 22, 2025

Conversation

kurtdoherty
Copy link
Contributor

Context

  • The Dialog component has received Design updates; we need to update our implementation to match.
  • The work will be done over a series of PRs:

This PR

  • Adds a new Dialog.Body subcomponent. It is not used or exposed yet, though docs are included for it.
Screenshot 2025-07-22 at 1 56 18 pm Screenshot 2025-07-22 at 1 56 26 pm

@rpt-uk-github
Copy link

rpt-uk-github commented Jul 22, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@github-actions github-actions bot closed this Jul 22, 2025
github-actions[bot]

This comment was marked as resolved.

@kurtdoherty kurtdoherty changed the title Add new Dialog.Body feat: Add new Dialog.Body Jul 22, 2025
@kurtdoherty kurtdoherty reopened this Jul 22, 2025
@kurtdoherty kurtdoherty force-pushed the feat-refactor-dialog-part-2 branch from 5734d84 to 20cafbf Compare July 22, 2025 04:35
@kurtdoherty kurtdoherty marked this pull request as ready for review July 22, 2025 04:36
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5cf8bda1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5cf8bda) Report Missing Report Missing Report Missing
Head commit (20cafbf) 7695 6971 90.59%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#630) 7 7 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty merged commit d3a63f2 into main Jul 22, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the feat-refactor-dialog-part-2 branch July 22, 2025 04:40
This was referenced Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants