Skip to content

feat: Add new Menu #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

feat: Add new Menu #643

merged 1 commit into from
Jul 30, 2025

Conversation

kurtdoherty
Copy link
Contributor

@kurtdoherty kurtdoherty commented Jul 30, 2025

Context

This PR

  • Adds new Menu component.

note: Keyboard navigation within the menu has been deferred for a future item of work.

Screenshot 2025-07-30 at 4 21 02 pm Screenshot 2025-07-30 at 4 21 20 pm

@rpt-uk-github
Copy link

rpt-uk-github commented Jul 30, 2025

Snyk checks have failed. 2 issues have been found so far.

Icon Severity Issues
Critical 0
High 2
Medium 0
Low 0

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. 2 issues have been found. (View Details)

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@kurtdoherty kurtdoherty force-pushed the feat-new-menu-part-5 branch from 9a08e1f to bc41851 Compare July 30, 2025 06:24
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 85aeadf1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (85aeadf) Report Missing Report Missing Report Missing
Head commit (bc41851) 8037 7313 90.99%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#643) 39 39 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty marked this pull request as ready for review July 30, 2025 06:47
@kurtdoherty kurtdoherty merged commit 1d1e6e2 into main Jul 30, 2025
5 of 7 checks passed
@kurtdoherty kurtdoherty deleted the feat-new-menu-part-5 branch July 30, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants