Skip to content

Comments

fix: border radius on Menu#645

Merged
kurtdoherty merged 1 commit intomainfrom
feat-new-menu-part-6
Jul 30, 2025
Merged

fix: border radius on Menu#645
kurtdoherty merged 1 commit intomainfrom
feat-new-menu-part-6

Conversation

@kurtdoherty
Copy link
Contributor

The new Menu's border radius is not working as expected. The popover's background is not transparent as intended, perhaps because of the box-shadow? 🤷 Either way, we need to shift the border-radius from the ElMenuContent styled element to the popover element itself.

Screenshot 2025-07-31 at 8 22 28 am

@rpt-uk-github
Copy link

rpt-uk-github commented Jul 30, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 1d1e6e21 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1d1e6e2) Report Missing Report Missing Report Missing
Head commit (0cbfc48) 8041 7317 91.00%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#645) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@@ -110,7 +110,7 @@ const meta = {
aria-controls={props.id}
aria-haspopup="menu"
id={props['aria-labelledby']}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: small scout. Making this helper a property of the Menu component means its future deprecation and removal will not require any changes to import statements in consumers.

import { Popover } from '#src/utils/popover'

import type { HTMLAttributes } from 'react'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this is now being exposed as a property on the Menu component

@kurtdoherty kurtdoherty marked this pull request as ready for review July 30, 2025 22:44
@kurtdoherty kurtdoherty merged commit 3ea3823 into main Jul 30, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the feat-new-menu-part-6 branch July 30, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants