fix: border radius on Menu #645
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
| @@ -110,7 +110,7 @@ const meta = { | |||
| aria-controls={props.id} | |||
| aria-haspopup="menu" | |||
| id={props['aria-labelledby']} | |||
There was a problem hiding this comment.
note: small scout. Making this helper a property of the Menu component means its future deprecation and removal will not require any changes to import statements in consumers.
| @@ -1,14 +1,12 @@ | |||
| import { AnchorMenuItem, MenuItem } from './item' | |||
| import { ElMenuContent } from './styles' | |||
| import { getPopoverTriggerProps as getMenuTriggerProps } from '#src/utils/popover' | |||
| import { MenuDivider } from './divider' | |||
| import { MenuGroup } from './group' | |||
| import { Popover } from '#src/utils/popover' | |||
|
|
|||
| import type { HTMLAttributes } from 'react' | |||
|
|
|||
There was a problem hiding this comment.
note: this is now being exposed as a property on the Menu component
The new Menu's border radius is not working as expected. The popover's background is not transparent as intended, perhaps because of the box-shadow? 🤷 Either way, we need to shift the border-radius from the ElMenuContent styled element to the popover element itself.