Skip to content

chore: use new Menu in BottomBar #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

Conversation

kurtdoherty
Copy link
Contributor

Context

  • We've recently made a new Menu component available.
  • We need to replace usage of the DeprecatedMenu within other Elements components with this new one.

This PR

  • Replaces the use of DeprecatedMenu in BottomBar.MenuItem with the new Menu.
  • Updates BottomBar.MenuItem to close the menu, if it's open, whenever the BottomBar collapses/closes.
Screenshot 2025-07-31 at 9 46 16 am

@rpt-uk-github
Copy link

rpt-uk-github commented Jul 30, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Copy link

codacy-production bot commented Jul 30, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for a75bd4f1 91.30%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a75bd4f) Report Missing Report Missing Report Missing
Head commit (7b31f0c) 8070 7342 90.98%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#646) 46 42 91.30%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty marked this pull request as ready for review July 30, 2025 23:52
@kurtdoherty kurtdoherty force-pushed the chore-use-new-menu-in-bottom-bar branch 2 times, most recently from 1d54bf6 to 488df17 Compare July 30, 2025 23:56
@kurtdoherty kurtdoherty force-pushed the chore-use-new-menu-in-bottom-bar branch from 488df17 to 7b31f0c Compare July 31, 2025 01:18
@kurtdoherty kurtdoherty merged commit 230f3f9 into main Jul 31, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the chore-use-new-menu-in-bottom-bar branch July 31, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants