Skip to content
This repository has been archived by the owner on Sep 27, 2020. It is now read-only.

Partial Genesis and TG16 (North American) theme #134

Closed
wants to merge 2 commits into from
Closed

Partial Genesis and TG16 (North American) theme #134

wants to merge 2 commits into from

Conversation

jaykass
Copy link
Contributor

@jaykass jaykass commented Jul 20, 2016

created theme folders for genesis and tg16. changed logo reference in theme.xml to use North American logos for each.

updates still needed for:
genesis/data/console.svg
genesis/data/controller.svg
genesis/data/controller2.svg
genesis/data/game.svg

tg16/data/console.svg

@paradadf
Copy link
Contributor

paradadf commented Jul 20, 2016

Why are you adding (needlessly) Megadrive/PC Engine stuff to the Genesis/Turbografx 16 folder you want to create? The only complicated part (speaking about themes) of adding a new system is vectorizing the images.

@jaykass
Copy link
Contributor Author

jaykass commented Jul 20, 2016

I just copied over the entire megadrive folder to genesis and likewise for pcengine to tg16.

I left all the files alone with the exception of editing the theme.xml file to display the NA logos. I figured leaving the other files would keep the theme complete even if it mixed megadrive with genesis and pcengine with tg16 until someone has a chance to create the proper vector graphics.

@paradadf
Copy link
Contributor

Why don't you first discuss the adding of extra themes in the blog or as an issue, instead of making a sort of "dirty" pull request? Nobody will invest time vectorizing the images if the work will be in vane.
And only to be clear, I say "dirty" meaning that you should have add only the correct logos if they are already available instead of copying the entire folder (e.g. changing logo2.svg to logo.svg). The other still not vectorized images can then easily be overwritten.

@jaykass
Copy link
Contributor Author

jaykass commented Jul 20, 2016

maybe I jumped ahead a little bit but I did add issue #131 which has a discussion ongoing.

@paradadf
Copy link
Contributor

I had seen the the issue. And I actually agree to it and would, when I have time, help with the drawings. But don't rush so much ;)

@paradadf
Copy link
Contributor

@jaykass I think it would be better to close your PR and wait until it is decided exactly how this would be done. I will little by little work on vectorizing the different systems and present them to the issue opened.

@jaykass jaykass closed this Jul 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants