Revert "feat: fixup openapi and related scripts & styles" #80
Conversation
This reverts commit af31f10.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: API Page Detection Fails for Reference Paths
The API page detection logic incorrectly checks for params.slug?.[0] === "reference". API reference pages are actually located under the api-reference path (e.g., api-reference/endpoints/). This prevents isApiPage from being true for these pages, leading to incorrect display of the Table of Contents and edit buttons. The check should be params.slug?.[0] === "api-reference".
app/[[...slug]]/page.tsx#L58-L59
Bug: Image Zoom Logic and Type Safety Issues
The img component's conditional logic to disable ImageZoom is brittle, relying on hardcoded alt text string matching (e.g., "Network", "Protocol") and className patterns. This approach is prone to breakage if partner names/alt texts change or new partners are added, and it doesn't reliably detect images within Card components as intended. Additionally, the (props as any) type cast when rendering a plain <img> element bypasses TypeScript's type checking, which is unsafe as ImageZoomProps may contain properties not valid for a standard HTML <img> element, potentially leading to runtime errors or invalid HTML attributes.
app/[[...slug]]/page.tsx#L28-L45
Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎
Reverts #79