WIP: Set testrun name for fusion and fdf deployments #12771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Coady LaCroix <[email protected]>
clacroix12
added
Needs Deployment Testing
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clacroix12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vavuthu
reviewed
Jul 24, 2025
Comment on lines
+2461
to
+2468
| if fdf_version: | ||
| product_version = f"FDF{fdf_version}" | ||
| elif fusion_version: | ||
| product_version = f"Fusion{fusion_version}" | ||
| elif ocs_version: | ||
| product_version = f"OCS{ocs_version}" | ||
| else: | ||
| product_version = "" |
There was a problem hiding this comment.
above will skip fusion_version if fdf_version exists. I think we need Fusion and FDF version in subject
There was a problem hiding this comment.
This was intentional as I didn't want to have both in the name of the launch. If fdf_version exists, I wanted it to take priority over fusion_version.
clacroix12
changed the title
Signed-off-by: Coady LaCroix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.