-
Notifications
You must be signed in to change notification settings - Fork 184
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
storageclusterpeer: implement logic for storageclusterpeer
Signed-off-by: Rewant Soni <[email protected]>
- Loading branch information
1 parent
502f1dd
commit 4f94c9e
Showing
2 changed files
with
139 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,46 +18,160 @@ package storageclusterpeer | |
|
||
import ( | ||
"context" | ||
"fmt" | ||
"github.com/red-hat-storage/ocs-operator/v4/controllers/util" | ||
"time" | ||
|
||
ocsv1 "github.com/red-hat-storage/ocs-operator/api/v4/v1" | ||
providerClient "github.com/red-hat-storage/ocs-operator/services/provider/api/v4/client" | ||
|
||
"github.com/go-logr/logr" | ||
"google.golang.org/grpc/status" | ||
k8serrors "k8s.io/apimachinery/pkg/api/errors" | ||
"k8s.io/apimachinery/pkg/runtime" | ||
ctrl "sigs.k8s.io/controller-runtime" | ||
"sigs.k8s.io/controller-runtime/pkg/client" | ||
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" | ||
"sigs.k8s.io/controller-runtime/pkg/log" | ||
"sigs.k8s.io/controller-runtime/pkg/reconcile" | ||
) | ||
|
||
v1 "github.com/red-hat-storage/ocs-operator/api/v4/v1" | ||
const ( | ||
storageClusterPeerFinalizer = "storageclusterpeer.ocs.openshift.io" | ||
) | ||
|
||
// StorageClusterPeerReconciler reconciles a StorageClusterPeer object | ||
// nolint:revive | ||
type StorageClusterPeerReconciler struct { | ||
client.Client | ||
Scheme *runtime.Scheme | ||
|
||
log logr.Logger | ||
ctx context.Context | ||
storageClusterPeer *ocsv1.StorageClusterPeer | ||
storageCluster *ocsv1.StorageCluster | ||
} | ||
|
||
// SetupWithManager sets up the controller with the Manager. | ||
func (r *StorageClusterPeerReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||
return ctrl.NewControllerManagedBy(mgr). | ||
For(&ocsv1.StorageClusterPeer{}). | ||
Complete(r) | ||
} | ||
|
||
//+kubebuilder:rbac:groups=ocs.openshift.io,resources=storageclusterpeers,verbs=get;list;watch;create;update;patch;delete | ||
//+kubebuilder:rbac:groups=ocs.openshift.io,resources=storageclusterpeers/status,verbs=get;update;patch | ||
//+kubebuilder:rbac:groups=ocs.openshift.io,resources=storageclusterpeers/finalizers,verbs=update | ||
//+kubebuilder:rbac:groups=ocs.openshift.io,resources=storageclusters,verbs=get;list;watch | ||
|
||
// Reconcile is part of the main kubernetes reconciliation loop which aims to | ||
// move the current state of the cluster closer to the desired state. | ||
// TODO(user): Modify the Reconcile function to compare the state specified by | ||
// the StorageClusterPeer object against the actual cluster state, and then | ||
// perform operations to make the cluster state reflect the state specified by | ||
// the user. | ||
// | ||
// For more details, check Reconcile and its Result here: | ||
// - https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/reconcile | ||
func (r *StorageClusterPeerReconciler) Reconcile(ctx context.Context, _ ctrl.Request) (ctrl.Result, error) { | ||
_ = log.FromContext(ctx) | ||
|
||
// TODO(user): your logic here | ||
func (r *StorageClusterPeerReconciler) Reconcile(ctx context.Context, request ctrl.Request) (ctrl.Result, error) { | ||
var err error | ||
r.ctx = ctx | ||
r.log = log.FromContext(ctx, "StorageClient", request) | ||
r.log.Info("Reconciling StorageClusterPeer.") | ||
|
||
// Fetch StorageCluster(s) | ||
r.storageCluster, err = util.GetStorageClusterInNamespace(r.ctx, r.Client, request.Namespace) | ||
if err != nil && k8serrors.IsNotFound(err) { | ||
r.log.Error(err, "StorageCluster for StorageClusterPeer found in the same namespace.") | ||
return ctrl.Result{}, err | ||
} | ||
|
||
// Fetch the StorageClusterPeer instance | ||
r.storageClusterPeer = &ocsv1.StorageClusterPeer{} | ||
r.storageClusterPeer.Name = request.Name | ||
r.storageClusterPeer.Namespace = request.Namespace | ||
|
||
if err = r.get(r.storageClusterPeer); err != nil { | ||
if k8serrors.IsNotFound(err) { | ||
r.log.Info("StorageClusterPeer resource not found. Ignoring since object must be deleted.") | ||
return reconcile.Result{}, nil | ||
} | ||
r.log.Error(err, "Failed to get StorageClusterPeer.") | ||
return reconcile.Result{}, err | ||
} | ||
|
||
result, reconcileErr := r.reconcilePhases() | ||
|
||
// Apply status changes to the StorageClient | ||
statusErr := r.Client.Status().Update(ctx, r.storageClusterPeer) | ||
if statusErr != nil { | ||
r.log.Error(statusErr, "Failed to update StorageClusterPeer status.") | ||
} | ||
|
||
if reconcileErr != nil { | ||
err = reconcileErr | ||
} else if statusErr != nil { | ||
err = statusErr | ||
} | ||
|
||
return result, err | ||
} | ||
|
||
func (r *StorageClusterPeerReconciler) reconcilePhases() (ctrl.Result, error) { | ||
ocsClient, err := r.newExternalClusterClient() | ||
if err != nil { | ||
return reconcile.Result{}, err | ||
} | ||
defer ocsClient.Close() | ||
|
||
// marked for deletion | ||
if !r.storageClusterPeer.GetDeletionTimestamp().IsZero() { | ||
//TODO: Removing PeerOCS Call | ||
|
||
if controllerutil.RemoveFinalizer(r.storageClusterPeer, storageClusterPeerFinalizer) { | ||
r.log.Info("removing finalizer from StorageClusterPeer.", "StorageClusterPeer", r.storageClusterPeer.Name) | ||
if err := r.update(r.storageClusterPeer); err != nil { | ||
r.log.Info("Failed to remove finalizer from StorageClusterPeer", "StorageClusterPeer", r.storageClusterPeer.Name) | ||
return reconcile.Result{}, fmt.Errorf("failed to remove finalizer from StorageClient: %v", err) | ||
} | ||
} | ||
} | ||
|
||
if controllerutil.AddFinalizer(r.storageClusterPeer, storageClusterPeerFinalizer) { | ||
r.log.Info("Finalizer not found for StorageClusterPeer. Adding finalizer.", "StorageClusterPeer", r.storageClusterPeer.Name) | ||
if err := r.update(r.storageClusterPeer); err != nil { | ||
return reconcile.Result{}, fmt.Errorf("failed to update StorageClusterPeer: %v", err) | ||
} | ||
} | ||
|
||
if r.storageClusterPeer.Status.State != ocsv1.StorageClusterPeerStatePeered { | ||
return r.peerOCS(ocsClient) | ||
} | ||
|
||
return ctrl.Result{}, nil | ||
} | ||
|
||
// SetupWithManager sets up the controller with the Manager. | ||
func (r *StorageClusterPeerReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||
return ctrl.NewControllerManagedBy(mgr). | ||
For(&v1.StorageClusterPeer{}). | ||
Complete(r) | ||
func (r *StorageClusterPeerReconciler) newExternalClusterClient() (*providerClient.OCSProviderClient, error) { | ||
|
||
ocsProviderClient, err := providerClient.NewProviderClient( | ||
r.ctx, r.storageClusterPeer.Spec.ApiEndpoint, time.Second*10) | ||
if err != nil { | ||
return nil, fmt.Errorf("failed to create a new provider client: %v", err) | ||
} | ||
|
||
return ocsProviderClient, nil | ||
} | ||
|
||
func (r *StorageClusterPeerReconciler) peerOCS(ocsClient *providerClient.OCSProviderClient) (ctrl.Result, error) { | ||
r.storageClusterPeer.Status.State = ocsv1.StorageClusterPeerStatePending | ||
response, err := ocsClient.PeerStorageCluster(r.ctx, r.storageClusterPeer.Spec.OnboardingToken, string(r.storageCluster.UID)) | ||
if err != nil { | ||
r.log.Error(err, fmt.Sprintf("failed to Peer Storage Cluster, code: %v.", status.Code(err))) | ||
return ctrl.Result{}, err | ||
} | ||
r.storageClusterPeer.Status.PeerInfo.StorageClusterUid = response.StorageClusterUID | ||
r.storageClusterPeer.Status.State = ocsv1.StorageClusterPeerStatePeered | ||
return ctrl.Result{}, nil | ||
} | ||
|
||
func (r *StorageClusterPeerReconciler) get(obj client.Object) error { | ||
key := client.ObjectKeyFromObject(obj) | ||
return r.Client.Get(r.ctx, key, obj) | ||
} | ||
|
||
func (r *StorageClusterPeerReconciler) update(obj client.Object, opts ...client.UpdateOption) error { | ||
return r.Client.Update(r.ctx, obj, opts...) | ||
} |