services: remove Getter as they generated as part of proto #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rchikatw
commented
Oct 17, 2024
rchikatw
commented
- remove Getter as they are generated as part of proto
- not removing GetPlatformVersion() & GetOperatorVersion() as they are already used. Leela will take care of removing this.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rchikatw The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rchikatw
force-pushed
the
addspecstorageconsumer
branch
from
f406618
to
68867da
Compare
Signed-off-by: rchikatw <[email protected]>
rchikatw
force-pushed
the
addspecstorageconsumer
branch
from
68867da
to
000fb1d
Compare
leelavg
reviewed
Oct 23, 2024
| @@ -207,7 +208,7 @@ func (c *ocsConsumerManager) Get(ctx context.Context, id string) (*ocsv1alpha1.S | |||
| return consumerObj, nil | |||
| } | |||
|
|
|||
| func (c *ocsConsumerManager) UpdateConsumerStatus(ctx context.Context, id string, status ifaces.StorageClientStatus) error { | |||
| func (c *ocsConsumerManager) UpdateConsumerStatus(ctx context.Context, id string, status *pb.ReportStatusRequest) error { | |||
There was a problem hiding this comment.
why is this being changed? the whole point was to abstract ReportStatusRequest as it keeps on increasing and keep on satisfying StorageClientStatus interface.
Comment on lines
8
to
-12
| GetOperatorVersion() string | ||
| GetClusterID() string | ||
| GetClusterName() string | ||
| GetClientName() string | ||
| GetStorageQuotaUtilizationRatio() float64 |
There was a problem hiding this comment.
can you change the comment to
These two getters are redirects for generated protobuf rpcs' and only add new getters here if you want to use different names which is not encouraged as these two are here only for backward compatibility
you can find setters at services/provider/api/storageclient.go and generated getters at services/provider/api/provider.pb.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.