Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: fix issue in cluster resource quota #2871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rchikatw
Copy link
Contributor

@rchikatw rchikatw commented Nov 4, 2024

  • Creating a resource of cluster resource quota on the client side does not limit storage usage for the default namespace by default.
  • Typically, application users do not have access to the default namespace; however, if an application admin attempts to create a Persistent Volume Claim (PVC) in the default namespace, the quota does not restrict this action.
  • BZ for this: https://bugzilla.redhat.com/show_bug.cgi?id=2318045

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rchikatw
Once this PR has been reviewed and has the lgtm label, please assign nbalacha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rchikatw
Copy link
Contributor Author

rchikatw commented Nov 4, 2024

@nb-ohad @leelavg please review

@leelavg
Copy link
Contributor

leelavg commented Nov 4, 2024

@rchikatw pls expand on description as it says what was happening but doesn't mention what this PR does to fix that?

The PR seems to be trying to not track consumption in namespace with name "default", shouldn't the fix for the BZ be an addition in documentation that PVC's in "default" namespace isn't counted towards quota calculations? Internally, an explanation why this can't be done in "default" namespace be added to BZ, wdyt?

@rchikatw
Copy link
Contributor Author

rchikatw commented Nov 4, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants